| Message ID | 20220416100502.627289-4-pgwipeout@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable rk356x PCIe controller | expand |
Hi Peter, On 4/16/22 13:05, Peter Geis wrote: > + pcie2x1: pcie@fe260000 { > + compatible = "rockchip,rk3568-pcie"; > + #address-cells = <3>; > + #size-cells = <2>; > + bus-range = <0x0 0xf>; > + assigned-clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>, > + <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>, > + <&cru CLK_PCIE20_AUX_NDFT>; Why these assigned-clocks are needed? I don't see anything assigned in this patchset.
On Sat, Apr 16, 2022 at 6:08 AM Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote: > > Hi Peter, > > On 4/16/22 13:05, Peter Geis wrote: > > + pcie2x1: pcie@fe260000 { > > + compatible = "rockchip,rk3568-pcie"; > > + #address-cells = <3>; > > + #size-cells = <2>; > > + bus-range = <0x0 0xf>; > > + assigned-clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>, > > + <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>, > > + <&cru CLK_PCIE20_AUX_NDFT>; > > Why these assigned-clocks are needed? I don't see anything assigned in > this patchset. Ah, those are remnants of early bringup when performance wasn't good and I was manually setting clock rates.
On 4/16/22 13:17, Peter Geis wrote: > On Sat, Apr 16, 2022 at 6:08 AM Dmitry Osipenko > <dmitry.osipenko@collabora.com> wrote: >> >> Hi Peter, >> >> On 4/16/22 13:05, Peter Geis wrote: >>> + pcie2x1: pcie@fe260000 { >>> + compatible = "rockchip,rk3568-pcie"; >>> + #address-cells = <3>; >>> + #size-cells = <2>; >>> + bus-range = <0x0 0xf>; >>> + assigned-clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>, >>> + <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>, >>> + <&cru CLK_PCIE20_AUX_NDFT>; >> >> Why these assigned-clocks are needed? I don't see anything assigned in >> this patchset. > > Ah, those are remnants of early bringup when performance wasn't good > and I was manually setting clock rates. If it's not needed, should it be removed then? Otherwise it looks like something is missing in the DT in regards to the assigned clocks.
On Sun, Apr 17, 2022 at 6:23 PM Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote: > > On 4/16/22 13:17, Peter Geis wrote: > > On Sat, Apr 16, 2022 at 6:08 AM Dmitry Osipenko > > <dmitry.osipenko@collabora.com> wrote: > >> > >> Hi Peter, > >> > >> On 4/16/22 13:05, Peter Geis wrote: > >>> + pcie2x1: pcie@fe260000 { > >>> + compatible = "rockchip,rk3568-pcie"; > >>> + #address-cells = <3>; > >>> + #size-cells = <2>; > >>> + bus-range = <0x0 0xf>; > >>> + assigned-clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>, > >>> + <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>, > >>> + <&cru CLK_PCIE20_AUX_NDFT>; > >> > >> Why these assigned-clocks are needed? I don't see anything assigned in > >> this patchset. > > > > Ah, those are remnants of early bringup when performance wasn't good > > and I was manually setting clock rates. > > If it's not needed, should it be removed then? Otherwise it looks like > something is missing in the DT in regards to the assigned clocks. Yes, it has been removed from the V7. Thanks!
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index ca20d7b91fe5..7408169f2865 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi @@ -722,6 +722,61 @@ qos_vop_m1: qos@fe1a8100 { reg = <0x0 0xfe1a8100 0x0 0x20>; }; + pcie2x1: pcie@fe260000 { + compatible = "rockchip,rk3568-pcie"; + #address-cells = <3>; + #size-cells = <2>; + bus-range = <0x0 0xf>; + assigned-clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>, + <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>, + <&cru CLK_PCIE20_AUX_NDFT>; + clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>, + <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>, + <&cru CLK_PCIE20_AUX_NDFT>; + clock-names = "aclk_mst", "aclk_slv", + "aclk_dbi", "pclk", "aux"; + device_type = "pci"; + interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "sys", "pmc", "msi", "legacy", "err"; + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 7>; + interrupt-map = <0 0 0 1 &pcie_intc 0>, + <0 0 0 2 &pcie_intc 1>, + <0 0 0 3 &pcie_intc 2>, + <0 0 0 4 &pcie_intc 3>; + linux,pci-domain = <0>; + num-ib-windows = <6>; + num-ob-windows = <2>; + max-link-speed = <2>; + msi-map = <0x0 &gic 0x0 0x1000>; + num-lanes = <1>; + phys = <&combphy2 PHY_TYPE_PCIE>; + phy-names = "pcie-phy"; + power-domains = <&power RK3568_PD_PIPE>; + reg = <0x3 0xc0000000 0x0 0x00400000>, + <0x0 0xfe260000 0x0 0x00010000>, + <0x3 0x00000000 0x0 0x01000000>; + ranges = <0x01000000 0x0 0x01000000 0x3 0x01000000 0x0 0x00100000 + 0x02000000 0x0 0x02000000 0x3 0x01100000 0x0 0x3ff00000>; + reg-names = "dbi", "apb", "config"; + resets = <&cru SRST_PCIE20_POWERUP>; + reset-names = "pipe"; + status = "disabled"; + + pcie_intc: legacy-interrupt-controller { + #address-cells = <0>; + #interrupt-cells = <1>; + interrupt-controller; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 72 IRQ_TYPE_EDGE_RISING>; + }; + + }; + sdmmc0: mmc@fe2b0000 { compatible = "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc"; reg = <0x0 0xfe2b0000 0x0 0x4000>;
The pcie2x1 controller is common between the rk3568 and rk3566. It is a single lane pcie2 compliant controller. Signed-off-by: Peter Geis <pgwipeout@gmail.com> --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 55 ++++++++++++++++++++++++ 1 file changed, 55 insertions(+)