| Message ID | 20220415083911.5186-11-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mediatek Soc DRM (vdosys0) support for mt8195 | expand |
Il 15/04/22 10:39, jason-jh.lin ha scritto: > After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, > mmsys header can remove the useless DDP_COMPONENT_DITHER enum. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> Can you please fix the commit title with: soc: mediatek: remove DDP_DOMPONENT_DITHER from enum that "from" is important, as you're not removing *an enum*, but *from an enum*. After that: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Thanks! Angelo
Hi Angelo, Thanks for the reviews. On Fri, 2022-04-15 at 12:32 +0200, AngeloGioacchino Del Regno wrote: > Il 15/04/22 10:39, jason-jh.lin ha scritto: > > After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, > > mmsys header can remove the useless DDP_COMPONENT_DITHER enum. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > Can you please fix the commit title with: > soc: mediatek: remove DDP_DOMPONENT_DITHER from enum > > that "from" is important, as you're not removing *an enum*, but *from > an enum*. > Yes, I agree with you. I'll fix it in the next version. Thanks. Regards, Jason-JH.Lin > After that: > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > Thanks! > Angelo
diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 59117d970daf..fb719fd1281c 100644 --- a/include/linux/soc/mediatek/mtk-mmsys.h +++ b/include/linux/soc/mediatek/mtk-mmsys.h @@ -16,8 +16,7 @@ enum mtk_ddp_comp_id { DDP_COMPONENT_CCORR, DDP_COMPONENT_COLOR0, DDP_COMPONENT_COLOR1, - DDP_COMPONENT_DITHER, - DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER, + DDP_COMPONENT_DITHER0, DDP_COMPONENT_DITHER1, DDP_COMPONENT_DP_INTF0, DDP_COMPONENT_DP_INTF1,
After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, mmsys header can remove the useless DDP_COMPONENT_DITHER enum. Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> --- include/linux/soc/mediatek/mtk-mmsys.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)