| Message ID | 20220418045314.360785-9-hch@lst.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4418bfd8fb9602d9cd8747c3ad52fdbaa02e2ffd |
| Headers | show |
| Series | [01/11] ubd: don't set the discard_alignment queue limit | expand |
On 4/18/22 13:53, Christoph Hellwig wrote: > The loop driver never sets a discard_alignment, so it also doens't need > to clear it to zero. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/block/loop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 976cf987b3920..61b642b966a08 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -789,7 +789,6 @@ static void loop_config_discard(struct loop_device *lo) > blk_queue_max_discard_sectors(q, 0); > blk_queue_max_write_zeroes_sectors(q, 0); > } > - q->limits.discard_alignment = 0; > } > > struct loop_worker { Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
On 4/17/22 21:53, Christoph Hellwig wrote: > The loop driver never sets a discard_alignment, so it also doens't need s/doens't/doesn't/ > to clear it to zero. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 976cf987b3920..61b642b966a08 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -789,7 +789,6 @@ static void loop_config_discard(struct loop_device *lo) blk_queue_max_discard_sectors(q, 0); blk_queue_max_write_zeroes_sectors(q, 0); } - q->limits.discard_alignment = 0; } struct loop_worker {
The loop driver never sets a discard_alignment, so it also doens't need to clear it to zero. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/loop.c | 1 - 1 file changed, 1 deletion(-)