[v5,net-next,1/4] rtnetlink: return ENODEV when ifname does not exist and group is given

Commit Message

Florent Fourcot April 15, 2022, 4:53 p.m. UTC

When the interface does not exist, and a group is given, the given
parameters are being set to all interfaces of the given group. The given
IFNAME/ALT_IF_NAME are being ignored in that case.

That can be dangerous since a typo (or a deleted interface) can produce
weird side effects for caller:

Case 1:

 IFLA_IFNAME=valid_interface
 IFLA_GROUP=1
 MTU=1234

Case 1 will update MTU and group of the given interface "valid_interface".

Case 2:

 IFLA_IFNAME=doesnotexist
 IFLA_GROUP=1
 MTU=1234

Case 2 will update MTU of all interfaces in group 1. IFLA_IFNAME is
ignored in this case

This behaviour is not consistent and dangerous. In order to fix this issue,
we now return ENODEV when the given IFNAME does not exist.

Signed-off-by: Florent Fourcot <[e-mail]>
Signed-off-by: Brian Baboch <[e-mail]>
---
 net/core/rtnetlink.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

Comments

Stephen Hemminger April 15, 2022, 7:24 p.m. UTC | #1

On Fri, 15 Apr 2022 18:53:27 +0200
Florent Fourcot <[e-mail]> wrote:

>  	if (!(nlh->nlmsg_flags & NLM_F_CREATE)) {
> -		if (ifm->ifi_index == 0 && tb[IFLA_GROUP])
> +		/* No dev found and NLM_F_CREATE not set. Requested dev does not exist,
> +		 * or it's for a group
> +		*/
> +		if (link_specified)
> +			return -ENODEV;

Please add extack error message as well?
Simple errno's are harder to debug.

Florent Fourcot April 19, 2022, 7:29 a.m. UTC | #2

Hello,


>> +		if (link_specified)
>> +			return -ENODEV;
> 
> Please add extack error message as well?
> Simple errno's are harder to debug.


What kind of message have you in mind for that one? Something like 
"Interface not found" does not have extra information for ENODEV code.

At this place, one gave interface index or interface name, and nothing 
matched.


Thanks,

Stephen Hemminger April 19, 2022, 3:04 p.m. UTC | #3

On Tue, 19 Apr 2022 09:29:37 +0200
Florent Fourcot <[e-mail]> wrote:

> Hello,
> 
> 
> >> +		if (link_specified)
> >> +			return -ENODEV;  
> > 
> > Please add extack error message as well?
> > Simple errno's are harder to debug.  
> 
> 
> What kind of message have you in mind for that one? Something like 
> "Interface not found" does not have extra information for ENODEV code.
> 
> At this place, one gave interface index or interface name, and nothing 
> matched.

Not sure how code gets here. Maybe "interface name required"

Patch

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 8bf770a7261e..2f538ab512d0 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -3326,6 +3326,7 @@  static int __rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
 	struct ifinfomsg *ifm;
 	char ifname[IFNAMSIZ];
 	struct nlattr **data;
+	bool link_specified;
 	int err;
 
 #ifdef CONFIG_MODULES
@@ -3346,12 +3347,16 @@  static int __rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
 		ifname[0] = '\0';
 
 	ifm = nlmsg_data(nlh);
-	if (ifm->ifi_index > 0)
+	if (ifm->ifi_index > 0) {
+		link_specified = true;
 		dev = __dev_get_by_index(net, ifm->ifi_index);
-	else if (tb[IFLA_IFNAME] || tb[IFLA_ALT_IFNAME])
+	} else if (tb[IFLA_IFNAME] || tb[IFLA_ALT_IFNAME]) {
+		link_specified = true;
 		dev = rtnl_dev_get(net, NULL, tb[IFLA_ALT_IFNAME], ifname);
-	else
+	} else {
+		link_specified = false;
 		dev = NULL;
+	}
 
 	master_dev = NULL;
 	m_ops = NULL;
@@ -3454,7 +3459,12 @@  static int __rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
 	}
 
 	if (!(nlh->nlmsg_flags & NLM_F_CREATE)) {
-		if (ifm->ifi_index == 0 && tb[IFLA_GROUP])
+		/* No dev found and NLM_F_CREATE not set. Requested dev does not exist,
+		 * or it's for a group
+		*/
+		if (link_specified)
+			return -ENODEV;
+		if (tb[IFLA_GROUP])
 			return rtnl_group_changelink(skb, net,
 						nla_get_u32(tb[IFLA_GROUP]),
 						ifm, extack, tb);