| Message ID | 20220419113734.3138095-2-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix apq8016 compat string | expand |
On Tue 19 Apr 04:37 PDT 2022, Bryan O'Donoghue wrote: > The documented yaml compat string for the apq8016 is > "qcom,apq8016-lpass-cpu" not "qcom,lpass-cpu-apq8016". Looking at the other > lpass compat strings the general form is "qcom,socnum-lpass-cpu". > > We need to fix both the driver and dts to match. > > Fixes: dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support") > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > sound/soc/qcom/lpass-apq8016.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c > index 3efa133d1c64..10edc5e9c8ef 100644 > --- a/sound/soc/qcom/lpass-apq8016.c > +++ b/sound/soc/qcom/lpass-apq8016.c > @@ -292,7 +292,7 @@ static struct lpass_variant apq8016_data = { > }; > > static const struct of_device_id apq8016_lpass_cpu_device_id[] __maybe_unused = { > - { .compatible = "qcom,lpass-cpu-apq8016", .data = &apq8016_data }, Removing this will break existing MSM8916 DTBs, so please retain this entry with a comment that it's the deprecated compatible. Regards, Bjorn > + { .compatible = "qcom,apq8016-lpass-cpu", .data = &apq8016_data }, > {} > }; > MODULE_DEVICE_TABLE(of, apq8016_lpass_cpu_device_id); > -- > 2.35.1 >
diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c index 3efa133d1c64..10edc5e9c8ef 100644 --- a/sound/soc/qcom/lpass-apq8016.c +++ b/sound/soc/qcom/lpass-apq8016.c @@ -292,7 +292,7 @@ static struct lpass_variant apq8016_data = { }; static const struct of_device_id apq8016_lpass_cpu_device_id[] __maybe_unused = { - { .compatible = "qcom,lpass-cpu-apq8016", .data = &apq8016_data }, + { .compatible = "qcom,apq8016-lpass-cpu", .data = &apq8016_data }, {} }; MODULE_DEVICE_TABLE(of, apq8016_lpass_cpu_device_id);
The documented yaml compat string for the apq8016 is "qcom,apq8016-lpass-cpu" not "qcom,lpass-cpu-apq8016". Looking at the other lpass compat strings the general form is "qcom,socnum-lpass-cpu". We need to fix both the driver and dts to match. Fixes: dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support") Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- sound/soc/qcom/lpass-apq8016.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)