| Message ID | 20220330023720.18238-1-qianggui.song@amlogic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] pinctrl: meson: fix unused variable warning | expand |
On 30/03/2022 04:37, Qianggui Song wrote: > The kernel test robot reported a warning as below: >>> drivers/pinctrl/meson/pinctrl-meson-s4.c:178:27: warning: unused variable 'tdm_sclk1_c_pins' [-Wunused-const-variable] > static const unsigned int tdm_sclk1_c_pins[] = { GPIOC_3 }; > > Fix it by adding missing description about this pins > > Fixes: 775214d389c2 ("pinctrl: meson: add pinctrl driver support for Meson-S4 Soc") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Qianggui Song <qianggui.song@amlogic.com> > --- > drivers/pinctrl/meson/pinctrl-meson-s4.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson-s4.c b/drivers/pinctrl/meson/pinctrl-meson-s4.c > index 3c7358f53302..cea77864b880 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson-s4.c > +++ b/drivers/pinctrl/meson/pinctrl-meson-s4.c > @@ -575,6 +575,7 @@ static struct meson_pmx_group meson_s4_periphs_groups[] = { > GROUP(tdm_d2_c, 4), > GROUP(tdm_d3_c, 4), > GROUP(tdm_fs1_c, 4), > + GROUP(tdm_sclk1_c, 4), > GROUP(mclk_1_c, 4), > GROUP(tdm_d4_c, 4), > GROUP(tdm_d5_c, 4), > @@ -936,7 +937,7 @@ static const char * const iso7816_groups[] = { > }; > > static const char * const tdm_groups[] = { > - "tdm_d2_c", "tdm_d3_c", "tdm_fs1_c", "tdm_d4_c", "tdm_d5_c", > + "tdm_d2_c", "tdm_d3_c", "tdm_fs1_c", "tdm_d4_c", "tdm_d5_c", "tdm_sclk1_c", > "tdm_fs1_d", "tdm_d4_d", "tdm_d3_d", "tdm_d2_d", "tdm_sclk1_d", > "tdm_sclk1_h", "tdm_fs1_h", "tdm_d2_h", "tdm_d3_h", "tdm_d4_h", > "tdm_d1", "tdm_d0", "tdm_fs0", "tdm_sclk0", "tdm_fs2", "tdm_sclk2", Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
On Wed, Mar 30, 2022 at 4:38 AM Qianggui Song <qianggui.song@amlogic.com> wrote: > The kernel test robot reported a warning as below: > >> drivers/pinctrl/meson/pinctrl-meson-s4.c:178:27: warning: unused variable 'tdm_sclk1_c_pins' [-Wunused-const-variable] > static const unsigned int tdm_sclk1_c_pins[] = { GPIOC_3 }; > > Fix it by adding missing description about this pins > > Fixes: 775214d389c2 ("pinctrl: meson: add pinctrl driver support for Meson-S4 Soc") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Qianggui Song <qianggui.song@amlogic.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/meson/pinctrl-meson-s4.c b/drivers/pinctrl/meson/pinctrl-meson-s4.c index 3c7358f53302..cea77864b880 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-s4.c +++ b/drivers/pinctrl/meson/pinctrl-meson-s4.c @@ -575,6 +575,7 @@ static struct meson_pmx_group meson_s4_periphs_groups[] = { GROUP(tdm_d2_c, 4), GROUP(tdm_d3_c, 4), GROUP(tdm_fs1_c, 4), + GROUP(tdm_sclk1_c, 4), GROUP(mclk_1_c, 4), GROUP(tdm_d4_c, 4), GROUP(tdm_d5_c, 4), @@ -936,7 +937,7 @@ static const char * const iso7816_groups[] = { }; static const char * const tdm_groups[] = { - "tdm_d2_c", "tdm_d3_c", "tdm_fs1_c", "tdm_d4_c", "tdm_d5_c", + "tdm_d2_c", "tdm_d3_c", "tdm_fs1_c", "tdm_d4_c", "tdm_d5_c", "tdm_sclk1_c", "tdm_fs1_d", "tdm_d4_d", "tdm_d3_d", "tdm_d2_d", "tdm_sclk1_d", "tdm_sclk1_h", "tdm_fs1_h", "tdm_d2_h", "tdm_d3_h", "tdm_d4_h", "tdm_d1", "tdm_d0", "tdm_fs0", "tdm_sclk0", "tdm_fs2", "tdm_sclk2",