| Message ID | 20220419180938.19397-2-y.oudjana@protonmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: arm: mediatek: Convert some docs to DT schema | expand |
On 19/04/2022 20:09, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Convert topckgen bindings to DT schema format. MT2701, MT7623 and > MT7629 device trees currently have the syscon compatible without > it being mentioned in the old DT bindings file which introduces > dtbs_check errors when converting to DT schema as-is, so > mediatek,mt2701-topckgen and mediatek,mt7629-topckgen are placed > in the last items list with the syscon compatible, and syscon is > added to the mediatek,mt7623-topckgen list. > Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml > new file mode 100644 > index 000000000000..9ce9cf673cbc > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,topckgen.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: MediaTek Top Clock Generator Controller > + > +maintainers: > + - Matthias Brugger <matthias.bgg@gmail.com> > + > +description: > + The Mediatek topckgen controller provides various clocks to the system. > + > +properties: > + compatible: > + oneOf: > + - items: These are not a list, so skip items. Just enum. Rest looks good. > + - enum: > + - mediatek,mt6797-topckgen > + - mediatek,mt7622-topckgen > + - mediatek,mt8135-topckgen > + - mediatek,mt8173-topckgen > + - mediatek,mt8516-topckgen Best regards, Krzysztof
On 20/04/2022 08:47, Krzysztof Kozlowski wrote: > On 19/04/2022 20:09, Yassine Oudjana wrote: >> From: Yassine Oudjana <y.oudjana@protonmail.com> >> >> Convert topckgen bindings to DT schema format. MT2701, MT7623 and >> MT7629 device trees currently have the syscon compatible without >> it being mentioned in the old DT bindings file which introduces >> dtbs_check errors when converting to DT schema as-is, so >> mediatek,mt2701-topckgen and mediatek,mt7629-topckgen are placed >> in the last items list with the syscon compatible, and syscon is >> added to the mediatek,mt7623-topckgen list. >> > > Thank you for your patch. There is something to discuss/improve. > >> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml >> new file mode 100644 >> index 000000000000..9ce9cf673cbc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml >> @@ -0,0 +1,60 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,topckgen.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: MediaTek Top Clock Generator Controller >> + >> +maintainers: >> + - Matthias Brugger <matthias.bgg@gmail.com> >> + >> +description: >> + The Mediatek topckgen controller provides various clocks to the system. >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: > > These are not a list, so skip items. Just enum. Rest looks good. Actually one more through - this looks like clock-controller, so please move the binding to ../bindings/clock/ directory. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt deleted file mode 100644 index b82422bb717f..000000000000 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt +++ /dev/null @@ -1,35 +0,0 @@ -Mediatek topckgen controller -============================ - -The Mediatek topckgen controller provides various clocks to the system. - -Required Properties: - -- compatible: Should be one of: - - "mediatek,mt2701-topckgen" - - "mediatek,mt2712-topckgen", "syscon" - - "mediatek,mt6765-topckgen", "syscon" - - "mediatek,mt6779-topckgen", "syscon" - - "mediatek,mt6797-topckgen" - - "mediatek,mt7622-topckgen" - - "mediatek,mt7623-topckgen", "mediatek,mt2701-topckgen" - - "mediatek,mt7629-topckgen" - - "mediatek,mt7986-topckgen", "syscon" - - "mediatek,mt8135-topckgen" - - "mediatek,mt8167-topckgen", "syscon" - - "mediatek,mt8173-topckgen" - - "mediatek,mt8183-topckgen", "syscon" - - "mediatek,mt8516-topckgen" -- #clock-cells: Must be 1 - -The topckgen controller uses the common clk binding from -Documentation/devicetree/bindings/clock/clock-bindings.txt -The available clocks are defined in dt-bindings/clock/mt*-clk.h. - -Example: - -topckgen: power-controller@10000000 { - compatible = "mediatek,mt8173-topckgen"; - reg = <0 0x10000000 0 0x1000>; - #clock-cells = <1>; -}; diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml new file mode 100644 index 000000000000..9ce9cf673cbc --- /dev/null +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,topckgen.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: MediaTek Top Clock Generator Controller + +maintainers: + - Matthias Brugger <matthias.bgg@gmail.com> + +description: + The Mediatek topckgen controller provides various clocks to the system. + +properties: + compatible: + oneOf: + - items: + - enum: + - mediatek,mt6797-topckgen + - mediatek,mt7622-topckgen + - mediatek,mt8135-topckgen + - mediatek,mt8173-topckgen + - mediatek,mt8516-topckgen + - items: + - const: mediatek,mt7623-topckgen + - const: mediatek,mt2701-topckgen + - const: syscon + - items: + - enum: + - mediatek,mt2701-topckgen + - mediatek,mt2712-topckgen + - mediatek,mt6765-topckgen + - mediatek,mt6779-topckgen + - mediatek,mt7629-topckgen + - mediatek,mt7986-topckgen + - mediatek,mt8167-topckgen + - mediatek,mt8183-topckgen + - const: syscon + + reg: + maxItems: 1 + + '#clock-cells': + const: 1 + +required: + - compatible + - reg + - '#clock-cells' + +additionalProperties: false + +examples: + - | + topckgen: clock-controller@10000000 { + compatible = "mediatek,mt8173-topckgen"; + reg = <0x10000000 0x1000>; + #clock-cells = <1>; + };