| Message ID | 20220420065832.14173-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: microchip: Add a missing semicolon | expand |
On 20/04/2022 06:58, Uwe Kleine-König wrote: > If the driver is configured as a module (after allowing this by changing > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the > compiler very unhappy. While there isn't a real problem as > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver, > do it right for consistency with other drivers. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and > some others) only bool. With this patch applied the driver compiles just > fine with PCIE_MICROCHIP_HOST=m. > > Best regards > Uwe I know ~nothing about the PCI driver itself, but I don't see why it wouldn't work as a module. I gave it a try & nothing has blown up in my face so far...
works fine too. No particular reason to keep it bool. Acked-by: Daire McNamara <daire.mcnamara@microchip.com> On Wed, 2022-04-20 at 08:58 +0200, Uwe Kleine-König wrote: > [You don't often get email from u.kleine-koenig@pengutronix.de. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification > .] > > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > If the driver is configured as a module (after allowing this by > changing > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon > makes the > compiler very unhappy. While there isn't a real problem as > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in > driver, > do it right for consistency with other drivers. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST > (and > some others) only bool. With this patch applied the driver compiles > just > fine with PCIE_MICROCHIP_HOST=m. > > Best regards > Uwe > > drivers/pci/controller/pcie-microchip-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-microchip-host.c > b/drivers/pci/controller/pcie-microchip-host.c > index 29d8e81e4181..4b1e130f88a3 100644 > --- a/drivers/pci/controller/pcie-microchip-host.c > +++ b/drivers/pci/controller/pcie-microchip-host.c > @@ -1115,7 +1115,7 @@ static const struct of_device_id > mc_pcie_of_match[] = { > {}, > }; > > -MODULE_DEVICE_TABLE(of, mc_pcie_of_match) > +MODULE_DEVICE_TABLE(of, mc_pcie_of_match); > > static struct platform_driver mc_pcie_driver = { > .probe = pci_host_common_probe, > -- > 2.35.1 >
On Wed, Apr 20, 2022 at 08:58:32AM +0200, Uwe Kleine-König wrote: > If the driver is configured as a module (after allowing this by changing > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the > compiler very unhappy. While there isn't a real problem as > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver, > do it right for consistency with other drivers. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and > some others) only bool. With this patch applied the driver compiles just > fine with PCIE_MICROCHIP_HOST=m. Historical copy-n-paste. Rob
On Wed, Apr 20, 2022 at 08:27:05AM -0500, Rob Herring wrote: > On Wed, Apr 20, 2022 at 08:58:32AM +0200, Uwe Kleine-König wrote: > > If the driver is configured as a module (after allowing this by changing > > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the > > compiler very unhappy. While there isn't a real problem as > > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver, > > do it right for consistency with other drivers. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > Hello, > > > > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and > > some others) only bool. With this patch applied the driver compiles just > > fine with PCIE_MICROCHIP_HOST=m. > > Historical copy-n-paste. For the record: I sent a patch to allow PCIE_MICROCHIP_HOST=m: https://lore.kernel.org/linux-pci/20220420093449.38054-1-u.kleine-koenig@pengutronix.de Best regards Uwe
On Wed, 20 Apr 2022 08:58:32 +0200, Uwe Kleine-König wrote: > If the driver is configured as a module (after allowing this by changing > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the > compiler very unhappy. While there isn't a real problem as > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver, > do it right for consistency with other drivers. > > > [...] Applied to pci/microchip, thanks! [1/1] PCI: microchip: Add a missing semicolon https://git.kernel.org/lpieralisi/pci/c/c049b4b376 Thanks, Lorenzo
diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c index 29d8e81e4181..4b1e130f88a3 100644 --- a/drivers/pci/controller/pcie-microchip-host.c +++ b/drivers/pci/controller/pcie-microchip-host.c @@ -1115,7 +1115,7 @@ static const struct of_device_id mc_pcie_of_match[] = { {}, }; -MODULE_DEVICE_TABLE(of, mc_pcie_of_match) +MODULE_DEVICE_TABLE(of, mc_pcie_of_match); static struct platform_driver mc_pcie_driver = { .probe = pci_host_common_probe,
If the driver is configured as a module (after allowing this by changing PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the compiler very unhappy. While there isn't a real problem as MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver, do it right for consistency with other drivers. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and some others) only bool. With this patch applied the driver compiles just fine with PCIE_MICROCHIP_HOST=m. Best regards Uwe drivers/pci/controller/pcie-microchip-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)