| Message ID | 20220413075141.72777-1-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | serial: 8250: dw: RZN1 DMA support | expand |
On Wed, Apr 13, 2022 at 09:51:30AM +0200, Miquel Raynal wrote: > Hello, > > Support for the RZN1 DMA engine allows us adapt a little bit the 8250 DW > UART driver with to bring DMA support for this SoC. > > This short series applies on top of the series bringing RZN1 DMA > support, currently on its v10, see [1]. Technically speaking, only the DT > patch needs to be applied after [1]. The other patches can come in at > any moment, because if no "dmas" property is provided in the DT, DMA > support will simply be ignored. > > [1] https://lore.kernel.org/dmaengine/20220412193936.63355-1-miquel.raynal@bootlin.com/T/#t Can you rebase on my tty-next branch please? This series does not apply anymore. thanks, greg k-h
Hi Greg, gregkh@linuxfoundation.org wrote on Fri, 15 Apr 2022 11:36:37 +0200: > On Wed, Apr 13, 2022 at 09:51:30AM +0200, Miquel Raynal wrote: > > Hello, > > > > Support for the RZN1 DMA engine allows us adapt a little bit the 8250 DW > > UART driver with to bring DMA support for this SoC. > > > > This short series applies on top of the series bringing RZN1 DMA > > support, currently on its v10, see [1]. Technically speaking, only the DT > > patch needs to be applied after [1]. The other patches can come in at > > any moment, because if no "dmas" property is provided in the DT, DMA > > support will simply be ignored. > > > > [1] https://lore.kernel.org/dmaengine/20220412193936.63355-1-miquel.raynal@bootlin.com/T/#t > > Can you rebase on my tty-next branch please? This series does not apply > anymore. Yes of course. Thanks, Miquèl
Hello, miquel.raynal@bootlin.com wrote on Wed, 20 Apr 2022 10:56:31 +0200: > Hi Greg, > > gregkh@linuxfoundation.org wrote on Fri, 15 Apr 2022 11:36:37 +0200: > > > On Wed, Apr 13, 2022 at 09:51:30AM +0200, Miquel Raynal wrote: > > > Hello, > > > > > > Support for the RZN1 DMA engine allows us adapt a little bit the 8250 DW > > > UART driver with to bring DMA support for this SoC. > > > > > > This short series applies on top of the series bringing RZN1 DMA > > > support, currently on its v10, see [1]. Technically speaking, only the DT > > > patch needs to be applied after [1]. The other patches can come in at > > > any moment, because if no "dmas" property is provided in the DT, DMA > > > support will simply be ignored. > > > > > > [1] https://lore.kernel.org/dmaengine/20220412193936.63355-1-miquel.raynal@bootlin.com/T/#t > > > > Can you rebase on my tty-next branch please? This series does not apply > > anymore. > > Yes of course. Actually the conflict comes from the fact that I was asked to rebase this series on top of a couple of changes for supporting a Starfive controller (jh7100-hsuart) which impacted the same area as I was touching. It turns out this series was not merged during the last merge cycle as expected. It seems to be because it received comments that were raised when reviewing my own series and which I actually fixed. Anyway, I've dropped the commit adding jh7100 support but squashed the patch bringing platform data to 8250_dw.c so that this series can now stand alone (see v6). It will be very easy to rebase the series from Emil on top of this one. Thanks, Miquèl
Hello, Support for the RZN1 DMA engine allows us adapt a little bit the 8250 DW UART driver with to bring DMA support for this SoC. This short series applies on top of the series bringing RZN1 DMA support, currently on its v10, see [1]. Technically speaking, only the DT patch needs to be applied after [1]. The other patches can come in at any moment, because if no "dmas" property is provided in the DT, DMA support will simply be ignored. [1] https://lore.kernel.org/dmaengine/20220412193936.63355-1-miquel.raynal@bootlin.com/T/#t Thanks, Miquèl Changes in v5: * Collected the various tags. * Updated the style to fit Andy's requests. * Moved the usr register offset to pdata as advised by Andy. * Moved the addition of the property.h header to the right patch. * Return earlier from the IRQ handler whenever possible. * Moved the dw8250_readl/writel_ext() helpers to dwlib.h so that they could be reused by the patch adding rzn1 support. Changes in v4: * Squashed the patch changing the quirks type with the patch introducing the pdata structure. This way I don't need to go through the uintptr_t step. * Added a pdata stub to the DW compatible. This way "if (pdata)" checks are no longer needed and we can avoid ternary operators disliked by Greg. * Saved the pdata structure pointer inside the per-device structure to avoid calling the same device property heplper over and over again. * Changed the style a bit to fit Andy's requirements. Changes in v3: * Added Geert's Reviewed-by's. * Used forward declaration in dwlib.h when relevant. * Reordered the headers when necessary. * Added a patch changing the quirks type from unsigned long to unsigned int as advised by Andy. * s/up->port.dev/p->dev/ when relevant. * Added a debug message in dwlib when no CPR is available. * Dropped the CPR_DMA_EXTRA bit addition: we assume DMA is there. * Changed the prefix of certain definitions. Changes in v2: * Rebased on top of Emil's patches. Added platform data structures instead of raw quirk integers in order to provide a CPR value. * Added includes in dwlib.h even though it's not particularly useful, it may help preventing a build error later on if we ever decide to include this file from another location. * Dropped the call to ->tx_dma and instead implemented a callback that can be called from serial8250_tx/rx_dma. * Used the device API instead of the of API. * Changed the logic about DMA capabilities to avoid breaking existing designs. * Introduced a new quirk related to the flow-control feature of the RZ/N1 version of the UART controller when used with DMA. * Re-arranged the entire series as advised by Andy and Geert. * Added several preparation patches to ease the review of various functional changes. Miquel Raynal (8): serial: 8250: dw: Use the device API serial: 8250: dw: Create a more generic platform data structure serial: 8250: dw: Move the USR register to pdata serial: 8250: dw: Allow to use a fallback CPR value if not synthesized serial: 8250: dma: Allow driver operations before starting DMA transfers serial: 8250: dw: Introduce an rx_timeout variable in the IRQ path serial: 8250: dw: Move the IO accessors to 8250_dwlib.h ARM: dts: r9a06g032: Fill the UART DMA properties Phil Edworthy (3): serial: 8250: dw: Move definitions to the shared header serial: 8250: dw: Add support for DMA flow controlling devices serial: 8250: dw: Improve RZN1 support arch/arm/boot/dts/r9a06g032.dtsi | 15 +++ drivers/tty/serial/8250/8250.h | 18 ++++ drivers/tty/serial/8250/8250_dma.c | 4 + drivers/tty/serial/8250/8250_dw.c | 135 ++++++++++++++++++++------- drivers/tty/serial/8250/8250_dwlib.c | 26 ++---- drivers/tty/serial/8250/8250_dwlib.h | 48 ++++++++++ 6 files changed, 195 insertions(+), 51 deletions(-)