| Message ID | 20220419081434.5192-1-boris.sukholitko@broadcom.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net/sched: flower: match on the number of vlan tags | expand |
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Tue, 19 Apr 2022 11:14:29 +0300 you wrote: > Hi, > > Our customers in the fiber telecom world have network configurations > where they would like to control their traffic according to the number > of tags appearing in the packet. > > For example, TR247 GPON conformance test suite specification mostly > talks about untagged, single, double tagged packets and gives lax > guidelines on the vlan protocol vs. number of vlan tags. > > [...] Here is the summary with links: - [net-next,v4,1/5] net/sched: flower: Helper function for vlan ethtype checks https://git.kernel.org/netdev/net-next/c/285ba06b0edb - [net-next,v4,2/5] net/sched: flower: Reduce identation after is_key_vlan refactoring https://git.kernel.org/netdev/net-next/c/6ee59e554d33 - [net-next,v4,3/5] flow_dissector: Add number of vlan tags dissector https://git.kernel.org/netdev/net-next/c/34951fcf26c5 - [net-next,v4,4/5] net/sched: flower: Add number of vlan tags filter https://git.kernel.org/netdev/net-next/c/b40003128226 - [net-next,v4,5/5] net/sched: flower: Consider the number of tags for vlan filters https://git.kernel.org/netdev/net-next/c/99fdb22bc5e9 You are awesome, thank you!
Hi, Our customers in the fiber telecom world have network configurations where they would like to control their traffic according to the number of tags appearing in the packet. For example, TR247 GPON conformance test suite specification mostly talks about untagged, single, double tagged packets and gives lax guidelines on the vlan protocol vs. number of vlan tags. This is different from the common IT networks where 802.1Q and 802.1ad protocols are usually describe single and double tagged packet. GPON configurations that we work with have arbitrary mix the above protocols and number of vlan tags in the packet. The following patch series implement number of vlans flower filter. They add num_of_vlans flower filter as an alternative to vlan ethtype protocol matching. The end result is that the following command becomes possible: tc filter add dev eth1 ingress flower \ num_of_vlans 1 vlan_prio 5 action drop Also, from our logs, we have redirect rules such that: tc filter add dev $GPON ingress flower num_of_vlans $N \ action mirred egress redirect dev $DEV where N can range from 0 to 3 and $DEV is the function of $N. Also there are rules setting skb mark based on the number of vlans: tc filter add dev $GPON ingress flower num_of_vlans $N vlan_prio \ $P action skbedit mark $M More about the patch series: - patches 1-2 remove duplicate code by introducing is_key_vlan helper. - patch 3, 4 implement num_of_vlans in the dissector and in the flower. - patch 5 uses the num_of_vlans filter to allow further matching on vlan attributes. Complementary iproute2 patches are being sent separately. Thanks, Boris. - v4: rebased to the latest net-next - v3: - more example commands in patch 3 description (request by Jamal) - patch 5 description made clearer (thanks to Jiri) - v2: - add suitable subject prefixes - more evolved patch 5 description Boris Sukholitko (5): net/sched: flower: Helper function for vlan ethtype checks net/sched: flower: Reduce identation after is_key_vlan refactoring flow_dissector: Add number of vlan tags dissector net/sched: flower: Add number of vlan tags filter net/sched: flower: Consider the number of tags for vlan filters include/net/flow_dissector.h | 9 ++++ include/uapi/linux/pkt_cls.h | 2 + net/core/flow_dissector.c | 20 ++++++++ net/sched/cls_flower.c | 90 +++++++++++++++++++++++------------- 4 files changed, 88 insertions(+), 33 deletions(-)