[v4,06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding

Commit Message

Hawkins, Nick April 20, 2022, 3:01 p.m. UTC

From: Nick Hawkins <[e-mail]>

Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
This will enable support for the HPE GXP Watchdog

Signed-off-by: Nick Hawkins <[e-mail]>

---
v2:
*Made watchdog a child of timer because of same register
area based on review feedback
*Simplified the watchdog yaml as it will get information
from parent device
---
 .../bindings/watchdog/hpe,gxp-wdt.yaml        | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml

Comments

Guenter Roeck April 20, 2022, 3:53 p.m. UTC | #1

On 4/20/22 08:01, [e-mail] wrote:
> From: Nick Hawkins <[e-mail]>
> 
> Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
> This will enable support for the HPE GXP Watchdog
> 
> Signed-off-by: Nick Hawkins <[e-mail]>
> 
> ---
> v2:

v3 and v4 changes are missing.

> *Made watchdog a child of timer because of same register
> area based on review feedback
> *Simplified the watchdog yaml as it will get information
> from parent device
> ---
>   .../bindings/watchdog/hpe,gxp-wdt.yaml        | 30 +++++++++++++++++++
>   1 file changed, 30 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
> new file mode 100644
> index 000000000000..c20da146352f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/hpe,gxp-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE GXP Controlled Watchdog
> +
> +allOf:
> +  - $ref: "watchdog.yaml#"
> +
> +maintainers:
> +  - Nick Hawkins <[e-mail]>
> +  - Jean-Marie Verdun <[e-mail]>
> +
> +properties:
> +  compatible:
> +    const: hpe,gxp-wdt
> +
> +required:
> +  - compatible
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    watchdog0:  watchdog {
> +      compatible = "hpe,gxp-wdt";
> +    };
> +

Hawkins, Nick April 20, 2022, 4:08 p.m. UTC | #2

-----Original Message-----
From: Guenter Roeck [mailto:[e-mail]] On Behalf Of Guenter Roeck
Sent: Wednesday, April 20, 2022 10:53 AM
To: Hawkins, Nick <[e-mail]>; Verdun, Jean-Marie <[e-mail]>; Harders, Nick <[e-mail]>; [e-mail]; [e-mail]
Cc: Wim Van Sebroeck <[e-mail]>; Rob Herring <[e-mail]>; [e-mail]; [e-mail]; [e-mail]
Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding

On 4/20/22 08:01, [e-mail] wrote:
> > From: Nick Hawkins <[e-mail]>
> > 
> > Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
> > This will enable support for the HPE GXP Watchdog
> > 
> > Signed-off-by: Nick Hawkins <[e-mail]>
> >
> > ---
> > v2:

> v3 and v4 changes are missing.

I considered this the second attempt with a valid patchset but I will change this to v4 and add v3 v2. Should I make a v5 to say I updated the patch message?

Regards,

-Nick

Guenter Roeck April 20, 2022, 4:36 p.m. UTC | #3

On 4/20/22 09:08, Hawkins, Nick wrote:
> 
> 
> -----Original Message-----
> From: Guenter Roeck [mailto:[e-mail]] On Behalf Of Guenter Roeck
> Sent: Wednesday, April 20, 2022 10:53 AM
> To: Hawkins, Nick <[e-mail]>; Verdun, Jean-Marie <[e-mail]>; Harders, Nick <[e-mail]>; [e-mail]; [e-mail]
> Cc: Wim Van Sebroeck <[e-mail]>; Rob Herring <[e-mail]>; [e-mail]; [e-mail]; [e-mail]
> Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
> 
> On 4/20/22 08:01, [e-mail] wrote:
>>> From: Nick Hawkins <[e-mail]>
>>>
>>> Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
>>> This will enable support for the HPE GXP Watchdog
>>>
>>> Signed-off-by: Nick Hawkins <[e-mail]>
>>>
>>> ---
>>> v2:
> 
>> v3 and v4 changes are missing.
> 
> I considered this the second attempt with a valid patchset but I will change this to v4 and add v3 v2. Should I make a v5 to say I updated the patch message?
> 

Sorry, I can't parse your statement. If there was no change in v3 and v4,
the change log for v3 and v4 should say "no changes in v3 and v4".
If the changes were made in v3 and/or v4, the change log should say that.
If the patch was added in v2/v3/v4, the change log should say that.
Either case, the last version in the change log should match the version
in the subject. Reviewers won't otherwise know how to match the patch
version with the change log. They will have to dig up v1..v3 to compare
the versions and find that out what exactly changed where (and why).
In my case, that commonly translates to "move patch to the end of my
review queue" because I just don't have the time to do that.

Guenter

Hawkins, Nick April 20, 2022, 5:15 p.m. UTC | #4

-----Original Message-----
From: Guenter Roeck [mailto:[e-mail]] On Behalf Of Guenter Roeck
Sent: Wednesday, April 20, 2022 11:37 AM
To: Hawkins, Nick <[e-mail]>; Verdun, Jean-Marie <[e-mail]>; Harders, Nick <[e-mail]>; [e-mail]; [e-mail]
Cc: Wim Van Sebroeck <[e-mail]>; Rob Herring <[e-mail]>; [e-mail]; [e-mail]; [e-mail]
Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding

On 4/20/22 09:08, Hawkins, Nick wrote:
> 
> 
> -----Original Message-----
> From: Guenter Roeck [mailto:[e-mail]] On Behalf Of Guenter 
> Roeck
> Sent: Wednesday, April 20, 2022 10:53 AM
> To: Hawkins, Nick <[e-mail]>; Verdun, Jean-Marie 
> <[e-mail]>; Harders, Nick <[e-mail]>; 
> [e-mail]; [e-mail]
> Cc: Wim Van Sebroeck <[e-mail]>; Rob Herring 
> <[e-mail]>; [e-mail]; 
> [e-mail]; [e-mail]
> Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP 
> Watchdog timer binding
> 
> On 4/20/22 08:01, [e-mail] wrote:
>>> From: Nick Hawkins <[e-mail]>
>>>
>>> Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
>>> This will enable support for the HPE GXP Watchdog
>>>
>>> Signed-off-by: Nick Hawkins <[e-mail]>
>>>
>>> ---
>>> v2:
> 
>> v3 and v4 changes are missing.
> 
> I considered this the second attempt with a valid patchset but I will change this to v4 and add v3 v2. Should I make a v5 to say I updated the patch message?
> 

> Sorry, I can't parse your statement. If there was no change in v3 and v4, the change log for v3 and v4 should say "no changes in v3 and v4".
> If the changes were made in v3 and/or v4, the change log should say that.
> If the patch was added in v2/v3/v4, the change log should say that.
> Either case, the last version in the change log should match the version in the subject. Reviewers won't otherwise know how to match the patch version with the change log. They will have to dig up v1..v3 to compare the versions and find that out what exactly changed where (and why).
> In my case, that commonly translates to "move patch to the end of my review queue" because I just don't have the time to do that.

Understood, I have gone through the entire patchset and updated versions to be in line with the patchset version number. The places where no changes were made I have put no changes.

Thanks for the feedback,

-Nick

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
new file mode 100644
index 000000000000..c20da146352f
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
@@ -0,0 +1,30 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/hpe,gxp-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HPE GXP Controlled Watchdog
+
+allOf:
+  - $ref: "watchdog.yaml#"
+
+maintainers:
+  - Nick Hawkins <[e-mail]>
+  - Jean-Marie Verdun <[e-mail]>
+
+properties:
+  compatible:
+    const: hpe,gxp-wdt
+
+required:
+  - compatible
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    watchdog0:  watchdog {
+      compatible = "hpe,gxp-wdt";
+    };
+