Message ID | 20220414230603.567049-4-chris.packham@alliedtelesis.co.nz (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | dt-bindings: mmc: Convert orion/dove bindings to JSON schema | expand |
On Fri, 15 Apr 2022 11:06:02 +1200, Chris Packham wrote: > Convert the orion-sdio binding to JSON schema. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > .../bindings/mmc/marvell,orion-sdio.yaml | 43 +++++++++++++++++++ > .../devicetree/bindings/mmc/orion-sdio.txt | 16 ------- > 2 files changed, 43 insertions(+), 16 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml > delete mode 100644 Documentation/devicetree/bindings/mmc/orion-sdio.txt > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ mvsdio@90000: $nodename:0: 'mvsdio@90000' does not match '^mmc(@.*)?$' arch/arm/boot/dts/kirkwood-b3.dtb arch/arm/boot/dts/kirkwood-blackarmor-nas220.dtb arch/arm/boot/dts/kirkwood-c200-v1.dtb arch/arm/boot/dts/kirkwood-cloudbox.dtb arch/arm/boot/dts/kirkwood-d2net.dtb arch/arm/boot/dts/kirkwood-db-88f6281.dtb arch/arm/boot/dts/kirkwood-db-88f6282.dtb arch/arm/boot/dts/kirkwood-dir665.dtb arch/arm/boot/dts/kirkwood-dns320.dtb arch/arm/boot/dts/kirkwood-dns325.dtb arch/arm/boot/dts/kirkwood-dockstar.dtb arch/arm/boot/dts/kirkwood-dreamplug.dtb arch/arm/boot/dts/kirkwood-ds109.dtb arch/arm/boot/dts/kirkwood-ds110jv10.dtb arch/arm/boot/dts/kirkwood-ds111.dtb arch/arm/boot/dts/kirkwood-ds112.dtb arch/arm/boot/dts/kirkwood-ds209.dtb arch/arm/boot/dts/kirkwood-ds210.dtb arch/arm/boot/dts/kirkwood-ds212.dtb arch/arm/boot/dts/kirkwood-ds212j.dtb arch/arm/boot/dts/kirkwood-ds409.dtb arch/arm/boot/dts/kirkwood-ds409slim.dtb arch/arm/boot/dts/kirkwood-ds411.dtb arch/arm/boot/dts/kirkwood-ds411j.dtb arch/arm/boot/dts/kirkwood-ds411slim.dtb arch/arm/boot/dts/kirkwood-goflexnet.dtb arch/arm/boot/dts/kirkwood-guruplug-server-plus.dtb arch/arm/boot/dts/kirkwood-ib62x0.dtb arch/arm/boot/dts/kirkwood-iconnect.dtb arch/arm/boot/dts/kirkwood-iomega_ix2_200.dtb arch/arm/boot/dts/kirkwood-is2.dtb arch/arm/boot/dts/kirkwood-l-50.dtb arch/arm/boot/dts/kirkwood-laplug.dtb arch/arm/boot/dts/kirkwood-linkstation-lsqvl.dtb arch/arm/boot/dts/kirkwood-linkstation-lsvl.dtb arch/arm/boot/dts/kirkwood-linkstation-lswsxl.dtb arch/arm/boot/dts/kirkwood-linkstation-lswvl.dtb arch/arm/boot/dts/kirkwood-linkstation-lswxl.dtb arch/arm/boot/dts/kirkwood-linksys-viper.dtb arch/arm/boot/dts/kirkwood-lschlv2.dtb arch/arm/boot/dts/kirkwood-lsxhl.dtb arch/arm/boot/dts/kirkwood-mplcec4.dtb arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dtb arch/arm/boot/dts/kirkwood-nas2big.dtb arch/arm/boot/dts/kirkwood-net2big.dtb arch/arm/boot/dts/kirkwood-net5big.dtb arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dtb arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dtb arch/arm/boot/dts/kirkwood-ns2.dtb arch/arm/boot/dts/kirkwood-ns2lite.dtb arch/arm/boot/dts/kirkwood-ns2max.dtb arch/arm/boot/dts/kirkwood-ns2mini.dtb arch/arm/boot/dts/kirkwood-nsa310a.dtb arch/arm/boot/dts/kirkwood-nsa310.dtb arch/arm/boot/dts/kirkwood-nsa320.dtb arch/arm/boot/dts/kirkwood-nsa325.dtb arch/arm/boot/dts/kirkwood-openblocks_a6.dtb arch/arm/boot/dts/kirkwood-openblocks_a7.dtb arch/arm/boot/dts/kirkwood-openrd-base.dtb arch/arm/boot/dts/kirkwood-openrd-client.dtb arch/arm/boot/dts/kirkwood-openrd-ultimate.dtb arch/arm/boot/dts/kirkwood-pogo_e02.dtb arch/arm/boot/dts/kirkwood-pogoplug-series-4.dtb arch/arm/boot/dts/kirkwood-rd88f6192.dtb arch/arm/boot/dts/kirkwood-rd88f6281-a.dtb arch/arm/boot/dts/kirkwood-rd88f6281-z0.dtb arch/arm/boot/dts/kirkwood-rs212.dtb arch/arm/boot/dts/kirkwood-rs409.dtb arch/arm/boot/dts/kirkwood-rs411.dtb arch/arm/boot/dts/kirkwood-sheevaplug.dtb arch/arm/boot/dts/kirkwood-sheevaplug-esata.dtb arch/arm/boot/dts/kirkwood-t5325.dtb arch/arm/boot/dts/kirkwood-topkick.dtb arch/arm/boot/dts/kirkwood-ts219-6281.dtb arch/arm/boot/dts/kirkwood-ts219-6282.dtb arch/arm/boot/dts/kirkwood-ts419-6281.dtb arch/arm/boot/dts/kirkwood-ts419-6282.dtb mvsdio@90000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed', 'broken-cd' were unexpected) arch/arm/boot/dts/kirkwood-dreamplug.dtb arch/arm/boot/dts/kirkwood-sheevaplug.dtb arch/arm/boot/dts/kirkwood-topkick.dtb mvsdio@90000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed', 'cd-gpios' were unexpected) arch/arm/boot/dts/kirkwood-l-50.dtb arch/arm/boot/dts/kirkwood-mplcec4.dtb arch/arm/boot/dts/kirkwood-openrd-base.dtb arch/arm/boot/dts/kirkwood-openrd-client.dtb arch/arm/boot/dts/kirkwood-openrd-ultimate.dtb arch/arm/boot/dts/kirkwood-rd88f6281-a.dtb arch/arm/boot/dts/kirkwood-rd88f6281-z0.dtb mvsdio@90000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed', 'cd-gpios', 'wp-gpios' were unexpected) arch/arm/boot/dts/kirkwood-pogoplug-series-4.dtb arch/arm/boot/dts/kirkwood-sheevaplug-esata.dtb mvsdio@90000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed', 'non-removable' were unexpected) arch/arm/boot/dts/kirkwood-guruplug-server-plus.dtb mvsdio@90000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed' were unexpected) arch/arm/boot/dts/kirkwood-b3.dtb arch/arm/boot/dts/kirkwood-blackarmor-nas220.dtb arch/arm/boot/dts/kirkwood-c200-v1.dtb arch/arm/boot/dts/kirkwood-cloudbox.dtb arch/arm/boot/dts/kirkwood-d2net.dtb arch/arm/boot/dts/kirkwood-dir665.dtb arch/arm/boot/dts/kirkwood-dns320.dtb arch/arm/boot/dts/kirkwood-dns325.dtb arch/arm/boot/dts/kirkwood-dockstar.dtb arch/arm/boot/dts/kirkwood-ds109.dtb arch/arm/boot/dts/kirkwood-ds110jv10.dtb arch/arm/boot/dts/kirkwood-ds111.dtb arch/arm/boot/dts/kirkwood-ds112.dtb arch/arm/boot/dts/kirkwood-ds209.dtb arch/arm/boot/dts/kirkwood-ds210.dtb arch/arm/boot/dts/kirkwood-ds212.dtb arch/arm/boot/dts/kirkwood-ds212j.dtb arch/arm/boot/dts/kirkwood-ds409.dtb arch/arm/boot/dts/kirkwood-ds409slim.dtb arch/arm/boot/dts/kirkwood-ds411.dtb arch/arm/boot/dts/kirkwood-ds411j.dtb arch/arm/boot/dts/kirkwood-ds411slim.dtb arch/arm/boot/dts/kirkwood-goflexnet.dtb arch/arm/boot/dts/kirkwood-ib62x0.dtb arch/arm/boot/dts/kirkwood-iconnect.dtb arch/arm/boot/dts/kirkwood-iomega_ix2_200.dtb arch/arm/boot/dts/kirkwood-is2.dtb arch/arm/boot/dts/kirkwood-laplug.dtb arch/arm/boot/dts/kirkwood-linkstation-lsqvl.dtb arch/arm/boot/dts/kirkwood-linkstation-lsvl.dtb arch/arm/boot/dts/kirkwood-linkstation-lswsxl.dtb arch/arm/boot/dts/kirkwood-linkstation-lswvl.dtb arch/arm/boot/dts/kirkwood-linkstation-lswxl.dtb arch/arm/boot/dts/kirkwood-linksys-viper.dtb arch/arm/boot/dts/kirkwood-lschlv2.dtb arch/arm/boot/dts/kirkwood-lsxhl.dtb arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dtb arch/arm/boot/dts/kirkwood-nas2big.dtb arch/arm/boot/dts/kirkwood-net2big.dtb arch/arm/boot/dts/kirkwood-net5big.dtb arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dtb arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dtb arch/arm/boot/dts/kirkwood-ns2.dtb arch/arm/boot/dts/kirkwood-ns2lite.dtb arch/arm/boot/dts/kirkwood-ns2max.dtb arch/arm/boot/dts/kirkwood-ns2mini.dtb arch/arm/boot/dts/kirkwood-nsa310a.dtb arch/arm/boot/dts/kirkwood-nsa310.dtb arch/arm/boot/dts/kirkwood-nsa320.dtb arch/arm/boot/dts/kirkwood-nsa325.dtb arch/arm/boot/dts/kirkwood-openblocks_a6.dtb arch/arm/boot/dts/kirkwood-openblocks_a7.dtb arch/arm/boot/dts/kirkwood-pogo_e02.dtb arch/arm/boot/dts/kirkwood-rd88f6192.dtb arch/arm/boot/dts/kirkwood-rs212.dtb arch/arm/boot/dts/kirkwood-rs409.dtb arch/arm/boot/dts/kirkwood-rs411.dtb arch/arm/boot/dts/kirkwood-t5325.dtb arch/arm/boot/dts/kirkwood-ts219-6281.dtb arch/arm/boot/dts/kirkwood-ts219-6282.dtb arch/arm/boot/dts/kirkwood-ts419-6281.dtb arch/arm/boot/dts/kirkwood-ts419-6282.dtb mvsdio@90000: Unevaluated properties are not allowed ('wp-gpios', 'cd-gpios', 'bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed' were unexpected) arch/arm/boot/dts/kirkwood-db-88f6281.dtb arch/arm/boot/dts/kirkwood-db-88f6282.dtb mvsdio@d4000: $nodename:0: 'mvsdio@d4000' does not match '^mmc(@.*)?$' arch/arm/boot/dts/armada-370-c200-v2.dtb arch/arm/boot/dts/armada-370-db.dtb arch/arm/boot/dts/armada-370-dlink-dns327l.dtb arch/arm/boot/dts/armada-370-mirabox.dtb arch/arm/boot/dts/armada-370-netgear-rn102.dtb arch/arm/boot/dts/armada-370-netgear-rn104.dtb arch/arm/boot/dts/armada-370-rd.dtb arch/arm/boot/dts/armada-370-seagate-nas-2bay.dtb arch/arm/boot/dts/armada-370-seagate-nas-4bay.dtb arch/arm/boot/dts/armada-370-seagate-personal-cloud-2bay.dtb arch/arm/boot/dts/armada-370-seagate-personal-cloud.dtb arch/arm/boot/dts/armada-370-synology-ds213j.dtb arch/arm/boot/dts/armada-375-db.dtb arch/arm/boot/dts/armada-xp-axpwifiap.dtb arch/arm/boot/dts/armada-xp-crs305-1g-4s-bit.dtb arch/arm/boot/dts/armada-xp-crs305-1g-4s.dtb arch/arm/boot/dts/armada-xp-crs326-24g-2s-bit.dtb arch/arm/boot/dts/armada-xp-crs326-24g-2s.dtb arch/arm/boot/dts/armada-xp-crs328-4c-20s-4s-bit.dtb arch/arm/boot/dts/armada-xp-crs328-4c-20s-4s.dtb arch/arm/boot/dts/armada-xp-db.dtb arch/arm/boot/dts/armada-xp-db-dxbc2.dtb arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dtb arch/arm/boot/dts/armada-xp-gp.dtb arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dtb arch/arm/boot/dts/armada-xp-linksys-mamba.dtb arch/arm/boot/dts/armada-xp-matrix.dtb arch/arm/boot/dts/armada-xp-netgear-rn2120.dtb arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dtb arch/arm/boot/dts/armada-xp-synology-ds414.dtb mvsdio@d4000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed', 'broken-cd' were unexpected) arch/arm/boot/dts/armada-370-db.dtb arch/arm/boot/dts/armada-370-mirabox.dtb arch/arm/boot/dts/armada-370-rd.dtb arch/arm/boot/dts/armada-xp-db.dtb arch/arm/boot/dts/armada-xp-db-dxbc2.dtb mvsdio@d4000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed', 'cd-gpios', 'wp-gpios' were unexpected) arch/arm/boot/dts/armada-375-db.dtb mvsdio@d4000: Unevaluated properties are not allowed ('bus-width', 'cap-sdio-irq', 'cap-sd-highspeed', 'cap-mmc-highspeed' were unexpected) arch/arm/boot/dts/armada-370-c200-v2.dtb arch/arm/boot/dts/armada-370-dlink-dns327l.dtb arch/arm/boot/dts/armada-370-netgear-rn102.dtb arch/arm/boot/dts/armada-370-netgear-rn104.dtb arch/arm/boot/dts/armada-370-seagate-nas-2bay.dtb arch/arm/boot/dts/armada-370-seagate-nas-4bay.dtb arch/arm/boot/dts/armada-370-seagate-personal-cloud-2bay.dtb arch/arm/boot/dts/armada-370-seagate-personal-cloud.dtb arch/arm/boot/dts/armada-370-synology-ds213j.dtb arch/arm/boot/dts/armada-xp-axpwifiap.dtb arch/arm/boot/dts/armada-xp-crs305-1g-4s-bit.dtb arch/arm/boot/dts/armada-xp-crs305-1g-4s.dtb arch/arm/boot/dts/armada-xp-crs326-24g-2s-bit.dtb arch/arm/boot/dts/armada-xp-crs326-24g-2s.dtb arch/arm/boot/dts/armada-xp-crs328-4c-20s-4s-bit.dtb arch/arm/boot/dts/armada-xp-crs328-4c-20s-4s.dtb arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dtb arch/arm/boot/dts/armada-xp-gp.dtb arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dtb arch/arm/boot/dts/armada-xp-linksys-mamba.dtb arch/arm/boot/dts/armada-xp-matrix.dtb arch/arm/boot/dts/armada-xp-netgear-rn2120.dtb arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dtb arch/arm/boot/dts/armada-xp-synology-ds414.dtb
On 15/04/2022 01:06, Chris Packham wrote: > Convert the orion-sdio binding to JSON schema. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > .../bindings/mmc/marvell,orion-sdio.yaml | 43 +++++++++++++++++++ > .../devicetree/bindings/mmc/orion-sdio.txt | 16 ------- > 2 files changed, 43 insertions(+), 16 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml > delete mode 100644 Documentation/devicetree/bindings/mmc/orion-sdio.txt > > diff --git a/Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml b/Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml > new file mode 100644 > index 000000000000..4fef53fc78ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/marvell,orion-sdio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell orion-sdio controller > + > +maintainers: > + - Ulf Hansson <ulf.hansson@linaro.org> This should be someone having taking care about this hardware, not subsystem maintainer. If there is no dedicated person for Marvell MMC, then maybe SoC maintainers? Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Apr 15, 2022 at 09:32:41AM -0500, Rob Herring wrote: > On Fri, 15 Apr 2022 11:06:02 +1200, Chris Packham wrote: > > Convert the orion-sdio binding to JSON schema. > > > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > > --- > > .../bindings/mmc/marvell,orion-sdio.yaml | 43 +++++++++++++++++++ > > .../devicetree/bindings/mmc/orion-sdio.txt | 16 ------- > > 2 files changed, 43 insertions(+), 16 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml > > delete mode 100644 Documentation/devicetree/bindings/mmc/orion-sdio.txt > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > mvsdio@90000: $nodename:0: 'mvsdio@90000' does not match '^mmc(@.*)?$' Looks like all these will be fixed with patch 1, so nothing to do here. Rob
diff --git a/Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml b/Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml new file mode 100644 index 000000000000..4fef53fc78ed --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mmc/marvell,orion-sdio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell orion-sdio controller + +maintainers: + - Ulf Hansson <ulf.hansson@linaro.org> + +allOf: + - $ref: mmc-controller.yaml# + +properties: + compatible: + const: marvell,orion-sdio + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +unevaluatedProperties: false + +examples: + - | + mmc@d00d4000 { + compatible = "marvell,orion-sdio"; + reg = <0xd00d4000 0x200>; + interrupts = <54>; + clocks = <&gateclk 17>; + }; diff --git a/Documentation/devicetree/bindings/mmc/orion-sdio.txt b/Documentation/devicetree/bindings/mmc/orion-sdio.txt deleted file mode 100644 index 10f0818a34c5..000000000000 --- a/Documentation/devicetree/bindings/mmc/orion-sdio.txt +++ /dev/null @@ -1,16 +0,0 @@ -* Marvell orion-sdio controller - -This file documents differences between the core properties in mmc.txt -and the properties used by the orion-sdio driver. - -- compatible: Should be "marvell,orion-sdio" -- clocks: reference to the clock of the SDIO interface - -Example: - - mvsdio@d00d4000 { - compatible = "marvell,orion-sdio"; - reg = <0xd00d4000 0x200>; - interrupts = <54>; - clocks = <&gateclk 17>; - };
Convert the orion-sdio binding to JSON schema. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- .../bindings/mmc/marvell,orion-sdio.yaml | 43 +++++++++++++++++++ .../devicetree/bindings/mmc/orion-sdio.txt | 16 ------- 2 files changed, 43 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/mmc/marvell,orion-sdio.yaml delete mode 100644 Documentation/devicetree/bindings/mmc/orion-sdio.txt