Message ID | 20220419114746.291613-1-shaozhengchao@huawei.com (mailing list archive) |
---|---|
State | Accepted |
Commit | db69264f983a5890fe8ba20ed4c20dfd4b687615 |
Delegated to: | BPF |
Headers | show |
Series | [bpf-next] samples/bpf: reduce the sampling interval in xdp1_user | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Tue, 19 Apr 2022 19:47:46 +0800 you wrote: > If interval is 2, and sum - prev[key] = 1, the result = 0. This will > mislead the tester that the port has no traffic right now. So reduce the > sampling interval to 1. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > samples/bpf/xdp1_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [bpf-next] samples/bpf: reduce the sampling interval in xdp1_user https://git.kernel.org/bpf/bpf-next/c/db69264f983a You are awesome, thank you!
diff --git a/samples/bpf/xdp1_user.c b/samples/bpf/xdp1_user.c index 631f0cabe139..bacebb4b602f 100644 --- a/samples/bpf/xdp1_user.c +++ b/samples/bpf/xdp1_user.c @@ -161,7 +161,7 @@ int main(int argc, char **argv) } prog_id = info.id; - poll_stats(map_fd, 2); + poll_stats(map_fd, 1); return 0; }
If interval is 2, and sum - prev[key] = 1, the result = 0. This will mislead the tester that the port has no traffic right now. So reduce the sampling interval to 1. Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- samples/bpf/xdp1_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)