[v3] hw/rx: rx-gdbsim DTB load address aligned of 16byte.

Commit Message

Yoshinori Sato Feb. 7, 2022, 1:27 p.m. UTC

Linux kernel required alined address of DTB.
But missing align in dtb load function.
Fixed to load to the correct address.

v3 changes.
Fix round value.

v2 changes.
Use ROUND_DOWN macro.

Signed-off-by: Yoshinori Sato <[e-mail]>
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
---
 hw/rx/rx-gdbsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson April 21, 2022, 5:07 p.m. UTC | #1

On 2/7/22 05:27, Yoshinori Sato wrote:
> Linux kernel required alined address of DTB.
> But missing align in dtb load function.
> Fixed to load to the correct address.
> 
> v3 changes.
> Fix round value.
> 
> v2 changes.
> Use ROUND_DOWN macro.
> 
> Signed-off-by: Yoshinori Sato <[e-mail]>
> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>

Queued to target-rx-next.


r~

Patch

diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c
index 75d1fec6ca..887083737b 100644
--- a/hw/rx/rx-gdbsim.c
+++ b/hw/rx/rx-gdbsim.c
@@ -142,7 +142,7 @@  static void rx_gdbsim_init(MachineState *machine)
                 exit(1);
             }
             /* DTB is located at the end of SDRAM space. */
-            dtb_offset = machine->ram_size - dtb_size;
+            dtb_offset = ROUND_DOWN(machine->ram_size - dtb_size, 16);
             rom_add_blob_fixed("dtb", dtb, dtb_size,
                                SDRAM_BASE + dtb_offset);
             /* Set dtb address to R1 */