[v3,0/2] soc: ti: wkup_m3_ipc: Add support for IO Isolation

Message

Drew Fustini April 14, 2022, 7:27 p.m. UTC

TI AM437x SoCs support isolation of the IOs so that control is taken
from the peripheral they are connected to and overridden by values
present in the control register for that pad. This series documents a
new property 'ti,set-io-isolation' and updates the wkup_m3_ipc driver to
inform the CM3 firmware when that property is set.

A prerequisite for this series is:
[PATCH v2 0/2] soc: ti: wkup_m3_ipc: support vtt toggle
https://lore.kernel.org/lkml/[e-mail]/T/

Changes from v2:
- correct indentation of the 'allOf:' block in binding patch

Changes from v1:
- correct typo of 'ti,set-io-isolation' property
- make 'ti,set-io-isolation' only valid for 'ti,am4372-wkup-m3-ipc'

Dave Gerlach (1):
  soc: ti: wkup_m3_ipc: Add support for IO Isolation

Drew Fustini (1):
  dt-bindings: wkup-m3-ipc: Add ti,set-io-isolation property

 .../bindings/soc/ti/wkup-m3-ipc.yaml          | 78 +++++++++++++++++--
 drivers/soc/ti/wkup_m3_ipc.c                  | 14 +++-
 include/linux/wkup_m3_ipc.h                   |  1 +
 3 files changed, 86 insertions(+), 7 deletions(-)

Comments

Tony Lindgren April 21, 2022, 6:56 a.m. UTC | #1

Hi,

* Drew Fustini <[e-mail]> [220414 19:24]:
> TI AM437x SoCs support isolation of the IOs so that control is taken
> from the peripheral they are connected to and overridden by values
> present in the control register for that pad. This series documents a
> new property 'ti,set-io-isolation' and updates the wkup_m3_ipc driver to
> inform the CM3 firmware when that property is set.

Care to list what hardware and board revisions you're able to test deep
sleep with?

Seems like my am437x-evm is too old for this where the board layout
does not match the schematics for removing a resistor to enable this.

Just wondering if I can still enable tests for this somehow :)

Regards,

Tony

Drew Fustini April 22, 2022, 5:10 a.m. UTC | #2

On Thu, Apr 21, 2022 at 09:56:03AM +0300, Tony Lindgren wrote:
> Hi,
> 
> * Drew Fustini <[e-mail]> [220414 19:24]:
> > TI AM437x SoCs support isolation of the IOs so that control is taken
> > from the peripheral they are connected to and overridden by values
> > present in the control register for that pad. This series documents a
> > new property 'ti,set-io-isolation' and updates the wkup_m3_ipc driver to
> > inform the CM3 firmware when that property is set.
> 
> Care to list what hardware and board revisions you're able to test deep
> sleep with?
> 
> Seems like my am437x-evm is too old for this where the board layout
> does not match the schematics for removing a resistor to enable this.
> 
> Just wondering if I can still enable tests for this somehow :)
> 
> Regards,
> 
> Tony

Do you know what revision of the am437x-gp-evm that you have?

The AM437X_GP_EVM_3K0006_SCHEMATIC_REV1_5B schematic [1] for the
AM437x-GP-EVM shows that the EN pin on the TPS51200 is connected to SoC
ball N25 which is GPIO5_7.

Unfortunately, the only AM437x board that I have is the AM437x IDK [2]
which unfortunately does not have the TSP51200 EN pin connected to the
the SoC. In addition, the am437x-gp-evm is the only board that is
allowed to enable off mode due to am43xx_check_off_mode_enable() in
arch/arm/mach-omap2/pm33xx-core.c

Thank you,
Drew

[1] https://www.ti.com/lit/zip/tidrc79
[2] https://www.ti.com/lit/zip/sprr396

Tony Lindgren April 26, 2022, 6:45 a.m. UTC | #3

* Drew Fustini <[e-mail]> [220422 05:06]:
> Do you know what revision of the am437x-gp-evm that you have?

Not sure, it seems to be some early revision the last time I looked.

> The AM437X_GP_EVM_3K0006_SCHEMATIC_REV1_5B schematic [1] for the
> AM437x-GP-EVM shows that the EN pin on the TPS51200 is connected to SoC
> ball N25 which is GPIO5_7.

OK

> Unfortunately, the only AM437x board that I have is the AM437x IDK [2]
> which unfortunately does not have the TSP51200 EN pin connected to the
> the SoC. In addition, the am437x-gp-evm is the only board that is
> allowed to enable off mode due to am43xx_check_off_mode_enable() in
> arch/arm/mach-omap2/pm33xx-core.c

OK

Thanks,

Tony


> [1] https://www.ti.com/lit/zip/tidrc79
> [2] https://www.ti.com/lit/zip/sprr396

Nishanth Menon May 3, 2022, 1:08 p.m. UTC | #4

Hi Drew Fustini,

On Thu, 14 Apr 2022 12:27:22 -0700, Drew Fustini wrote:
> TI AM437x SoCs support isolation of the IOs so that control is taken
> from the peripheral they are connected to and overridden by values
> present in the control register for that pad. This series documents a
> new property 'ti,set-io-isolation' and updates the wkup_m3_ipc driver to
> inform the CM3 firmware when that property is set.
> 
> A prerequisite for this series is:
> [PATCH v2 0/2] soc: ti: wkup_m3_ipc: support vtt toggle
> https://lore.kernel.org/lkml/[e-mail]/T/
> 
> [...]

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[2/2] soc: ti: wkup_m3_ipc: Add support for IO Isolation
      commit: 1dcbae86ee669bdb0338954cd0136863f5c96c0a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git