[v5,0/2] Option to take screenshot with screendump as PNG

Message

Kshitij Suri April 8, 2022, 7:13 a.m. UTC

This patch series aims to add PNG support using libpng to screendump method.
Currently screendump only supports PPM format, which is uncompressed.

PATCH 1 phases out CONFIG_VNC_PNG parameter and replaces it with CONFIG_PNG
which detects libpng support.

PATCH 2 contains core logic for PNG creation from pixman using libpng. HMP
command equivalent is also implemented in this patch.

v4->v5
 - Modified format as a flag based optional parameter in HMP.

v3->v4
 - Added condition to check for libpng only in PNG option is allowed

v2->v3
 - HMP implementation fixes for png.
 - Used enum for image format.
 - Fixed description and updated QEMU support version.

v1->v2:
 - Removed repeated alpha conversion operation.
 - Modified logic to mirror png conversion in vnc-enc-tight.c file.
 - Added a new CONFIG_PNG parameter for libpng support.
 - Changed input format to enum instead of string.
 - Improved error handling.

Kshitij Suri (2):
  Replacing CONFIG_VNC_PNG with CONFIG_PNG
  Added parameter to take screenshot with screendump as PNG

 hmp-commands.hx    |  11 ++---
 meson.build        |  12 +++---
 meson_options.txt  |   4 +-
 monitor/hmp-cmds.c |  12 +++++-
 qapi/ui.json       |  24 +++++++++--
 ui/console.c       | 101 +++++++++++++++++++++++++++++++++++++++++++--
 ui/vnc-enc-tight.c |  18 ++++----
 ui/vnc.c           |   4 +-
 ui/vnc.h           |   2 +-
 9 files changed, 157 insertions(+), 31 deletions(-)

Comments

Kshitij Suri April 14, 2022, 8:55 a.m. UTC | #1

Hi,

Hope this mail finds everyone well! I have updated the code as required 
and would be grateful if I could get your reviews for any changes that 
are needed to be implemented in the patch. In case no change is 
required, please do let me know the next steps for the same.

Regards,

Kshitij Suri

On 08/04/22 12:43 pm, Kshitij Suri wrote:
> This patch series aims to add PNG support using libpng to screendump method.
> Currently screendump only supports PPM format, which is uncompressed.
>
> PATCH 1 phases out CONFIG_VNC_PNG parameter and replaces it with CONFIG_PNG
> which detects libpng support.
>
> PATCH 2 contains core logic for PNG creation from pixman using libpng. HMP
> command equivalent is also implemented in this patch.
>
> v4->v5
>   - Modified format as a flag based optional parameter in HMP.
>
> v3->v4
>   - Added condition to check for libpng only in PNG option is allowed
>
> v2->v3
>   - HMP implementation fixes for png.
>   - Used enum for image format.
>   - Fixed description and updated QEMU support version.
>
> v1->v2:
>   - Removed repeated alpha conversion operation.
>   - Modified logic to mirror png conversion in vnc-enc-tight.c file.
>   - Added a new CONFIG_PNG parameter for libpng support.
>   - Changed input format to enum instead of string.
>   - Improved error handling.
>
> Kshitij Suri (2):
>    Replacing CONFIG_VNC_PNG with CONFIG_PNG
>    Added parameter to take screenshot with screendump as PNG
>
>   hmp-commands.hx    |  11 ++---
>   meson.build        |  12 +++---
>   meson_options.txt  |   4 +-
>   monitor/hmp-cmds.c |  12 +++++-
>   qapi/ui.json       |  24 +++++++++--
>   ui/console.c       | 101 +++++++++++++++++++++++++++++++++++++++++++--
>   ui/vnc-enc-tight.c |  18 ++++----
>   ui/vnc.c           |   4 +-
>   ui/vnc.h           |   2 +-
>   9 files changed, 157 insertions(+), 31 deletions(-)
>

Markus Armbruster April 21, 2022, 1:57 p.m. UTC | #2

Kshitij Suri <[e-mail]> writes:

> Hi,
>
> Hope this mail finds everyone well! I have updated the code as
> required and would be grateful if I could get your reviews for any
> changes that are needed to be implemented in the patch. In case no
> change is required, please do let me know the next steps for the same.

Unless something still comes up in review, the next step is merging.

Gerd, would you like to take it?

Gerd Hoffmann April 22, 2022, 10:50 a.m. UTC | #3

On Thu, Apr 21, 2022 at 03:57:30PM +0200, Markus Armbruster wrote:
> Kshitij Suri <[e-mail]> writes:
> 
> > Hi,
> >
> > Hope this mail finds everyone well! I have updated the code as
> > required and would be grateful if I could get your reviews for any
> > changes that are needed to be implemented in the patch. In case no
> > change is required, please do let me know the next steps for the same.
> 
> Unless something still comes up in review, the next step is merging.
> 
> Gerd, would you like to take it?

I'm busy going through the backlog (patches not merged during freeze)
anyway.  Queued this now.

take care,
  Gerd