[v6,5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192

Commit Message

Xinlei Lee (李昕磊) April 18, 2022, 12:20 p.m. UTC

From: Xinlei Lee <[e-mail]>

Add interrupts property of pwm for MediaTek MT8192 SoC.

Signed-off-by: Xinlei Lee <[e-mail]>
---
 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

AngeloGioacchino Del Regno April 21, 2022, 10:17 a.m. UTC | #1

Il 18/04/22 14:20, [e-mail] ha scritto:
> From: Xinlei Lee <[e-mail]>
> 
> Add interrupts property of pwm for MediaTek MT8192 SoC.
> 
> Signed-off-by: Xinlei Lee <[e-mail]>

Hello Xinlei,
the pwm-mtk-disp.c driver does not support interrupts.

Please add interrupts support to the driver first, and only then
add that in the dt-bindings.

Regards,
Angelo

Uwe Kleine-König April 21, 2022, 1:48 p.m. UTC | #2

Hello,

On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote:
> Il 18/04/22 14:20, [e-mail] ha scritto:
> > From: Xinlei Lee <[e-mail]>
> > 
> > Add interrupts property of pwm for MediaTek MT8192 SoC.
> > 
> > Signed-off-by: Xinlei Lee <[e-mail]>
> 
> Hello Xinlei,
> the pwm-mtk-disp.c driver does not support interrupts.
> 
> Please add interrupts support to the driver first, and only then
> add that in the dt-bindings.

in my understanding the linux driver state and the binding documentation
are somewhat independent. Here I'd say adding the irq information to dt
without the driver supporting it is fine.

Best regards
Uwe

Thierry Reding April 22, 2022, 4:57 p.m. UTC | #3

On Thu, Apr 21, 2022 at 03:48:08PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote:
> > Il 18/04/22 14:20, [e-mail] ha scritto:
> > > From: Xinlei Lee <[e-mail]>
> > > 
> > > Add interrupts property of pwm for MediaTek MT8192 SoC.
> > > 
> > > Signed-off-by: Xinlei Lee <[e-mail]>
> > 
> > Hello Xinlei,
> > the pwm-mtk-disp.c driver does not support interrupts.
> > 
> > Please add interrupts support to the driver first, and only then
> > add that in the dt-bindings.
> 
> in my understanding the linux driver state and the binding documentation
> are somewhat independent. Here I'd say adding the irq information to dt
> without the driver supporting it is fine.

Agreed. I've applied this along with the rest. It doesn't have Rob's or
Krzysztof's stamp of approval, but it's a trivial change and looks fine
to me.

Thierry

Patch

diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 4b71bd668d33..e4fe2d1bfef5 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -37,6 +37,9 @@  properties:
   "#pwm-cells":
     const: 2
 
+  interrupts:
+    maxItems: 1
+
   clocks:
     items:
       - description: Main Clock