| Message ID | 20220421070440.1282704-1-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: unexport csum_and_copy_{from,to}_user | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Thu, 21 Apr 2022 09:04:40 +0200 Christoph Hellwig wrote: > csum_and_copy_from_user and csum_and_copy_to_user are exported by > a few architectures, but not actually used in modular code. Drop > the exports. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Judging by the To: I presume the intention is for Andrew to take this one, so FWIW: Acked-by: Jakub Kicinski <kuba@kernel.org>
On Fri, Apr 22, 2022 at 11:14 PM Christoph Hellwig <hch@lst.de> wrote: > csum_and_copy_from_user and csum_and_copy_to_user are exported by > a few architectures, but not actually used in modular code. Drop > the exports. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > arch/m68k/lib/checksum.c | 2 -- Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Apr 21, 2022 at 9:04 AM Christoph Hellwig <hch@lst.de> wrote: > > csum_and_copy_from_user and csum_and_copy_to_user are exported by > a few architectures, but not actually used in modular code. Drop > the exports. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Arnd Bergmann <arnd@arndb.de>
Christoph Hellwig <hch@lst.de> writes: > csum_and_copy_from_user and csum_and_copy_to_user are exported by > a few architectures, but not actually used in modular code. Drop > the exports. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > arch/alpha/lib/csum_partial_copy.c | 1 - > arch/m68k/lib/checksum.c | 2 -- > arch/powerpc/lib/checksum_wrappers.c | 2 -- > arch/x86/lib/csum-wrappers_64.c | 2 -- > 4 files changed, 7 deletions(-) Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers
On Thu, Apr 21, 2022 at 09:04:40AM +0200, Christoph Hellwig wrote: > csum_and_copy_from_user and csum_and_copy_to_user are exported by > a few architectures, but not actually used in modular code. Drop > the exports. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Al Viro <viro@zeniv.linux.org.uk> Not sure which tree should it go through - Arnd's, perhaps?
Al Viro <viro@zeniv.linux.org.uk> writes: > On Thu, Apr 21, 2022 at 09:04:40AM +0200, Christoph Hellwig wrote: >> csum_and_copy_from_user and csum_and_copy_to_user are exported by >> a few architectures, but not actually used in modular code. Drop >> the exports. >> >> Signed-off-by: Christoph Hellwig <hch@lst.de> > > Acked-by: Al Viro <viro@zeniv.linux.org.uk> > > Not sure which tree should it go through - Arnd's, perhaps? It's already in akpm's tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-nonmm-stable&id=6308499b5e99c0c903fde2c605e41d9a86c4be6c cheers
diff --git a/arch/alpha/lib/csum_partial_copy.c b/arch/alpha/lib/csum_partial_copy.c index 1931a04af85a2..4d180d96f09e4 100644 --- a/arch/alpha/lib/csum_partial_copy.c +++ b/arch/alpha/lib/csum_partial_copy.c @@ -353,7 +353,6 @@ csum_and_copy_from_user(const void __user *src, void *dst, int len) return 0; return __csum_and_copy(src, dst, len); } -EXPORT_SYMBOL(csum_and_copy_from_user); __wsum csum_partial_copy_nocheck(const void *src, void *dst, int len) diff --git a/arch/m68k/lib/checksum.c b/arch/m68k/lib/checksum.c index 7e6afeae62177..5acb821849d30 100644 --- a/arch/m68k/lib/checksum.c +++ b/arch/m68k/lib/checksum.c @@ -265,8 +265,6 @@ csum_and_copy_from_user(const void __user *src, void *dst, int len) return sum; } -EXPORT_SYMBOL(csum_and_copy_from_user); - /* * copy from kernel space while checksumming, otherwise like csum_partial diff --git a/arch/powerpc/lib/checksum_wrappers.c b/arch/powerpc/lib/checksum_wrappers.c index f3999cbb2fcc4..1a14c8780278c 100644 --- a/arch/powerpc/lib/checksum_wrappers.c +++ b/arch/powerpc/lib/checksum_wrappers.c @@ -24,7 +24,6 @@ __wsum csum_and_copy_from_user(const void __user *src, void *dst, user_read_access_end(); return csum; } -EXPORT_SYMBOL(csum_and_copy_from_user); __wsum csum_and_copy_to_user(const void *src, void __user *dst, int len) { @@ -38,4 +37,3 @@ __wsum csum_and_copy_to_user(const void *src, void __user *dst, int len) user_write_access_end(); return csum; } -EXPORT_SYMBOL(csum_and_copy_to_user); diff --git a/arch/x86/lib/csum-wrappers_64.c b/arch/x86/lib/csum-wrappers_64.c index 189344924a2be..145f9a0bde29a 100644 --- a/arch/x86/lib/csum-wrappers_64.c +++ b/arch/x86/lib/csum-wrappers_64.c @@ -32,7 +32,6 @@ csum_and_copy_from_user(const void __user *src, void *dst, int len) user_access_end(); return sum; } -EXPORT_SYMBOL(csum_and_copy_from_user); /** * csum_and_copy_to_user - Copy and checksum to user space. @@ -57,7 +56,6 @@ csum_and_copy_to_user(const void *src, void __user *dst, int len) user_access_end(); return sum; } -EXPORT_SYMBOL(csum_and_copy_to_user); /** * csum_partial_copy_nocheck - Copy and checksum.
csum_and_copy_from_user and csum_and_copy_to_user are exported by a few architectures, but not actually used in modular code. Drop the exports. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/alpha/lib/csum_partial_copy.c | 1 - arch/m68k/lib/checksum.c | 2 -- arch/powerpc/lib/checksum_wrappers.c | 2 -- arch/x86/lib/csum-wrappers_64.c | 2 -- 4 files changed, 7 deletions(-)