| Message ID | 20220418205509.1102109-4-bhupesh.sharma@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix dtbs_check warning(s) for Qualcomm QMP PHY | expand |
On Mon 18 Apr 13:55 PDT 2022, Bhupesh Sharma wrote: > Currently the qcom,qmp-phy dt-binding doesn't describe > the 'reg' and '#phy-cells' properties for the phy@ subnode. > > Fix the same. > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index 411c79dbfa15..c553c8ad0d1a 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -118,6 +118,19 @@ patternProperties: > Each device node of QMP phy is required to have as many child nodes as > the number of lanes the PHY has. > properties: > + reg: > + minItems: 1 > + maxItems: 6 > + items: > + description: | > + List of offset and length pairs of register sets for PHY blocks. > + common block control registers, such as - SW_RESET, START_CTRL. > + pcs registers, such as - PCS_STATUS, POWER_DOWN_CONTROL, > + pcs misc registers, such as - PCS_MISC_TYPEC_CTRL. The two cases we have is: tx rx pcs pcs_misc and: tx rx pcs tx2 rx2 pcs_misc So I think we should express that explicitly here. Regards, Bjorn > + > + "#phy-cells": > + const: 0 > + > "#clock-cells": > enum: [ 0, 1, 2 ] > > -- > 2.35.1 >
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 411c79dbfa15..c553c8ad0d1a 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -118,6 +118,19 @@ patternProperties: Each device node of QMP phy is required to have as many child nodes as the number of lanes the PHY has. properties: + reg: + minItems: 1 + maxItems: 6 + items: + description: | + List of offset and length pairs of register sets for PHY blocks. + common block control registers, such as - SW_RESET, START_CTRL. + pcs registers, such as - PCS_STATUS, POWER_DOWN_CONTROL, + pcs misc registers, such as - PCS_MISC_TYPEC_CTRL. + + "#phy-cells": + const: 0 + "#clock-cells": enum: [ 0, 1, 2 ]
Currently the qcom,qmp-phy dt-binding doesn't describe the 'reg' and '#phy-cells' properties for the phy@ subnode. Fix the same. Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)