| Message ID | cover.1650580763.git.peilin.ye@bytedance.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Make [IP6]GRE[TAP] devices always NETIF_F_LLTX | expand |
On Thu, 21 Apr 2022 15:43:42 -0700 Peilin Ye wrote: > This patchset depends on these fixes [1]. Since o_seqno is now atomic_t, > we can always turn on NETIF_F_LLTX for [IP6]GRE[TAP] devices, since we no > longer need the TX lock (&txq->_xmit_lock). LGTM, thanks, but please repost on Thu / Fri. The fixes make their way into net-next on Thu so until then we can't apply. > We could probably do the same thing to [IP6]ERSPAN devices as well, but > I'm not familiar with them yet. For example, ERSPAN devices are > initialized as |= GRE_FEATURES in erspan_tunnel_init(), but I don't see > IP6ERSPAN devices being initialized as |= GRE6_FEATURES. Please suggest > if I'm missing something, thanks! Probably good to CC William when you repost.
Hi Jakub, On Mon, Apr 25, 2022 at 11:02:59AM -0700, Jakub Kicinski wrote: > On Thu, 21 Apr 2022 15:43:42 -0700 Peilin Ye wrote: > > This patchset depends on these fixes [1]. Since o_seqno is now atomic_t, > > we can always turn on NETIF_F_LLTX for [IP6]GRE[TAP] devices, since we no > > longer need the TX lock (&txq->_xmit_lock). > > LGTM, thanks, but please repost on Thu / Fri. The fixes make their way > into net-next on Thu so until then we can't apply. Thanks for the review! > > We could probably do the same thing to [IP6]ERSPAN devices as well, but > > I'm not familiar with them yet. For example, ERSPAN devices are > > initialized as |= GRE_FEATURES in erspan_tunnel_init(), but I don't see > > IP6ERSPAN devices being initialized as |= GRE6_FEATURES. Please suggest > > if I'm missing something, thanks! > > Probably good to CC William when you repost. Sure, I will resend then. Thanks, Peilin Ye
From: Peilin Ye <peilin.ye@bytedance.com> Hi all, This patchset depends on these fixes [1]. Since o_seqno is now atomic_t, we can always turn on NETIF_F_LLTX for [IP6]GRE[TAP] devices, since we no longer need the TX lock (&txq->_xmit_lock). We could probably do the same thing to [IP6]ERSPAN devices as well, but I'm not familiar with them yet. For example, ERSPAN devices are initialized as |= GRE_FEATURES in erspan_tunnel_init(), but I don't see IP6ERSPAN devices being initialized as |= GRE6_FEATURES. Please suggest if I'm missing something, thanks! [1] https://lore.kernel.org/netdev/cover.1650575919.git.peilin.ye@bytedance.com/ Thanks, Peilin Ye (2): ip_gre: Make GRE and GRETAP devices always NETIF_F_LLTX ip6_gre: Make IP6GRE and IP6GRETAP devices always NETIF_F_LLTX net/ipv4/ip_gre.c | 50 ++++++++++++++++++++-------------------------- net/ipv6/ip6_gre.c | 34 ++++++++++++------------------- 2 files changed, 35 insertions(+), 49 deletions(-)