[v2,0/3] hwmon: (dell-smm) Improve init code

Message

Armin Wolf April 26, 2022, 9:31 p.m. UTC

This patch series improves the init code of the dell_smm_hwmon
driver. The first patch speeds up device initialisation by avoiding
unnecessary SMM calls during init, which might be slow on some
machines. The second patch is a small cleanup patch, while the
third patch allows for easier diagnosis of audio problems caused
by really slow SMM calls.

Tested on a Dell Inspiron 3505.

Changes in v2:
- replace pr_warn() with pr_warn_once()

Armin Wolf (3):
  hwmon: (dell-smm) Avoid unnecessary SMM calls during init
  hwmon: (dell-smm) Cleanup init code
  hwmon: (dell-smm) Warn if SMM call took a very long time to execute

 drivers/hwmon/dell-smm-hwmon.c | 50 +++++++++++++++-------------------
 1 file changed, 22 insertions(+), 28 deletions(-)

--
2.30.2

Comments

Guenter Roeck April 27, 2022, 3:35 a.m. UTC | #1

On 4/26/22 14:31, Armin Wolf wrote:
> This patch series improves the init code of the dell_smm_hwmon
> driver. The first patch speeds up device initialisation by avoiding
> unnecessary SMM calls during init, which might be slow on some
> machines. The second patch is a small cleanup patch, while the
> third patch allows for easier diagnosis of audio problems caused
> by really slow SMM calls.
> 
> Tested on a Dell Inspiron 3505.

Series applied to hwmon-next.

Thanks,
Guenter

> 
> Changes in v2:
> - replace pr_warn() with pr_warn_once()
> 
> Armin Wolf (3):
>    hwmon: (dell-smm) Avoid unnecessary SMM calls during init
>    hwmon: (dell-smm) Cleanup init code
>    hwmon: (dell-smm) Warn if SMM call took a very long time to execute
> 
>   drivers/hwmon/dell-smm-hwmon.c | 50 +++++++++++++++-------------------
>   1 file changed, 22 insertions(+), 28 deletions(-)
> 
> --
> 2.30.2
>