| Message ID | 62b8375ae008035bcaa85c348ea4aa80c519bb07.1651037513.git.lukas@wunner.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Polling be gone on LAN95xx | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 27.04.22 07:48, Lukas Wunner wrote: > If reading the Interrupt Source Flag register fails with -ENODEV, then > the PHY has been hot-removed and the correct response is to bail out > instead of throwing a WARN splat and attempting to suspend the PHY. > The PHY should be stopped in due course anyway as the kernel > asynchronously tears down the device. > > Signed-off-by: Lukas Wunner <lukas@wunner.de> > --- > drivers/net/phy/smsc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > index a521d48b22a7..35bff7fd234c 100644 > --- a/drivers/net/phy/smsc.c > +++ b/drivers/net/phy/smsc.c > @@ -91,7 +91,9 @@ static irqreturn_t smsc_phy_handle_interrupt(struct phy_device *phydev) > > irq_status = phy_read(phydev, MII_LAN83C185_ISF); > if (irq_status < 0) { > - phy_error(phydev); > + if (irq_status != -ENODEV) > + phy_error(phydev); > + > return IRQ_NONE; > } > Hi, picking a small nit, if you get ENODEV, you have no idea whether the irq was caused by the phy. Strictly speaking you should return IRQ_HANDLED in that case. Regards Oliver
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index a521d48b22a7..35bff7fd234c 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -91,7 +91,9 @@ static irqreturn_t smsc_phy_handle_interrupt(struct phy_device *phydev) irq_status = phy_read(phydev, MII_LAN83C185_ISF); if (irq_status < 0) { - phy_error(phydev); + if (irq_status != -ENODEV) + phy_error(phydev); + return IRQ_NONE; }
If reading the Interrupt Source Flag register fails with -ENODEV, then the PHY has been hot-removed and the correct response is to bail out instead of throwing a WARN splat and attempting to suspend the PHY. The PHY should be stopped in due course anyway as the kernel asynchronously tears down the device. Signed-off-by: Lukas Wunner <lukas@wunner.de> --- drivers/net/phy/smsc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)