| Message ID | 20220427160255.300418-4-p.raghav@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/16] block: make blkdev_nr_zones and blk_queue_zone_no generic for npo2 zsze | expand |
On 4/28/22 01:02, Pankaj Raghav wrote: > Many places in the filesystem for zoned devices open code this function > to find the zone number for a given sector with power of 2 assumption. > This generic helper can be used to calculate zone number for a given > sector in a block device > > This helper internally uses blk_queue_zone_no to find the zone number. > > Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> > --- > include/linux/blkdev.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index f8f2d2998afb..55293e0a8702 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1392,6 +1392,15 @@ static inline bool bdev_zone_aligned(struct block_device *bdev, sector_t sec) > return false; > } > > +static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec) > +{ > + struct request_queue *q = bdev_get_queue(bdev); > + > + if (q) q is never NULL. So this can be simplified to: return blk_queue_zone_no(bdev_get_queue(bdev), sector); > + return blk_queue_zone_no(q, sec); > + return 0; > +} > + > static inline unsigned int bdev_max_open_zones(struct block_device *bdev) > { > struct request_queue *q = bdev_get_queue(bdev);
On 4/27/22 09:02, Pankaj Raghav wrote: > +static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec) > +{ > + struct request_queue *q = bdev_get_queue(bdev); > + > + if (q) > + return blk_queue_zone_no(q, sec); > + return 0; > +} This patch series has been split incorrectly: the same patch that introduces a new function should also introduce a caller to that function. Thanks, Bart.
On 2022-04-28 01:53, Bart Van Assche wrote: > On 4/27/22 09:02, Pankaj Raghav wrote: >> +static inline unsigned int bdev_zone_no(struct block_device *bdev, >> sector_t sec) >> +{ >> + struct request_queue *q = bdev_get_queue(bdev); >> + >> + if (q) >> + return blk_queue_zone_no(q, sec); >> + return 0; >> +} > > This patch series has been split incorrectly: the same patch that > introduces a new function should also introduce a caller to that function. > Acked. I will make sure this happens in the next revision. Thanks. > Thanks, > > Bart.
On 2022-04-28 01:31, Damien Le Moal wrote: >> +static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec) >> +{ >> + struct request_queue *q = bdev_get_queue(bdev); >> + >> + if (q) > > q is never NULL. So this can be simplified to: > That is a good point. I just noticed it in the bdev_get_queue() function that q can never be NULL. I will fix it up. All the functions `bdev*` have this pattern, so probably they could be simplified as well in the future. > return blk_queue_zone_no(bdev_get_queue(bdev), sector); > >> + return blk_queue_zone_no(q, sec); >> + return 0; >> +} >> + >> static inline unsigned int bdev_max_open_zones(struct block_device *bdev) >> { >> struct request_queue *q = bdev_get_queue(bdev); > >
On 4/27/22 09:02, Pankaj Raghav wrote: > Many places in the filesystem for zoned devices open code this function > to find the zone number for a given sector with power of 2 assumption. > This generic helper can be used to calculate zone number for a given > sector in a block device > > This helper internally uses blk_queue_zone_no to find the zone number. > > Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> > --- > include/linux/blkdev.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index f8f2d2998afb..55293e0a8702 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1392,6 +1392,15 @@ static inline bool bdev_zone_aligned(struct block_device *bdev, sector_t sec) return false; } +static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec) +{ + struct request_queue *q = bdev_get_queue(bdev); + + if (q) + return blk_queue_zone_no(q, sec); + return 0; +} + static inline unsigned int bdev_max_open_zones(struct block_device *bdev) { struct request_queue *q = bdev_get_queue(bdev);