| Message ID | 20220426170306.v22.2.I18481b296484eec47bdc292a31fa46fa8c655ca9@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v22,1/2] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub | expand |
Quoting Matthias Kaehlcke (2022-04-26 17:03:23) > Add nodes for the onboard USB hub on herobrine devices. Remove the > 'always-on' property from the hub regulator, since the regulator > is now managed by the onboard_usb_hub driver. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Hi, On Tue, Apr 26, 2022 at 5:03 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > Add nodes for the onboard USB hub on herobrine devices. Remove the > 'always-on' property from the hub regulator, since the regulator > is now managed by the onboard_usb_hub driver. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > Changes in v22: > - patch added to the series > > .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) Just like on patch #1, I presume it will be moderately annoying if this lands in the Qualcomm branch before the driver lands in mainline? I guess very few people have herobrine hardware, so maybe not that big of a deal... In any case, I'm happy with: Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Wed, Apr 27, 2022 at 02:06:00PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Apr 26, 2022 at 5:03 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > Add nodes for the onboard USB hub on herobrine devices. Remove the > > 'always-on' property from the hub regulator, since the regulator > > is now managed by the onboard_usb_hub driver. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > > > Changes in v22: > > - patch added to the series > > > > .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 21 ++++++++++++++++++- > > 1 file changed, 20 insertions(+), 1 deletion(-) > > Just like on patch #1, I presume it will be moderately annoying if > this lands in the Qualcomm branch before the driver lands in mainline? > I guess very few people have herobrine hardware, so maybe not that big > of a deal... For herobrine it's probably not a big deal, hardware isn't publicly available and those who have run it with a CrOS based kernel most of the time. But yeah, it would be somewhat annoying if USB is broken when you test something with an upstream kernel. > In any case, I'm happy with: > > Reviewed-by: Douglas Anderson <dianders@chromium.org> Thanks!
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index d58045dd7334..46937d21b229 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -143,8 +143,8 @@ pp3300_hub: pp3300-hub-regulator { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + /* The BIOS leaves this regulator on */ regulator-boot-on; - regulator-always-on; gpio = <&tlmm 157 GPIO_ACTIVE_HIGH>; enable-active-high; @@ -560,6 +560,25 @@ &usb_1 { &usb_1_dwc3 { dr_mode = "host"; + + #address-cells = <1>; + #size-cells = <0>; + + /* 2.x hub on port 1 */ + usb_hub_2_x: hub@1 { + compatible = "usbbda,5411"; + reg = <1>; + vdd-supply = <&pp3300_hub>; + companion-hub = <&usb_hub_3_x>; + }; + + /* 3.x hub on port 2 */ + usb_hub_3_x: hub@2 { + compatible = "usbbda,411"; + reg = <2>; + vdd-supply = <&pp3300_hub>; + companion-hub = <&usb_hub_2_x>; + }; }; &usb_1_hsphy {
Add nodes for the onboard USB hub on herobrine devices. Remove the 'always-on' property from the hub regulator, since the regulator is now managed by the onboard_usb_hub driver. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v22: - patch added to the series .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-)