| Message ID | 20220425032802.365061-1-gshan@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | hw/arm/virt: Fix CPU's default NUMA node ID | expand |
Hi Peter and maintainers, On 4/25/22 11:27 AM, Gavin Shan wrote: > When the CPU-to-NUMA association isn't provided by user, the default NUMA > node ID for the specific CPU is returned from virt_get_default_cpu_node_id(). > Unfortunately, the default NUMA node ID breaks socket boundary and leads to > the broken CPU topology warning message in Linux guest. This series intends > to fix the issue. > > PATCH[1/5] Add cluster-id to CPU instance property > PATCH[2/5] Fixes test failure in qtest/numa-test/aarch64_numa_cpu() > PATCH[3/5] Uses SMP configuration to populate CPU topology > PATCH[4/5] Fixes the broken CPU topology by considering the socket boundary > when the default NUMA node ID is given > PATCH[5/5] Uses the populated CPU topology to build PPTT table, instead of > calculate it again > Could you help to check if it's eligible for 7.1? Thanks a lot for your comments in advance. [...] > > Gavin Shan (5): > qapi/machine.json: Add cluster-id > qtest/numa-test: Specify CPU topology in aarch64_numa_cpu() > hw/arm/virt: Consider SMP configuration in CPU topology > hw/arm/virt: Fix CPU's default NUMA node ID > hw/acpi/aml-build: Use existing CPU topology to build PPTT table > > hw/acpi/aml-build.c | 111 ++++++++++++++++--------------------- > hw/arm/virt.c | 19 ++++++- > hw/core/machine-hmp-cmds.c | 4 ++ > hw/core/machine.c | 16 ++++++ > qapi/machine.json | 6 +- > tests/qtest/numa-test.c | 3 +- > 6 files changed, 91 insertions(+), 68 deletions(-) > Thanks, Gavin
When the CPU-to-NUMA association isn't provided by user, the default NUMA node ID for the specific CPU is returned from virt_get_default_cpu_node_id(). Unfortunately, the default NUMA node ID breaks socket boundary and leads to the broken CPU topology warning message in Linux guest. This series intends to fix the issue. PATCH[1/5] Add cluster-id to CPU instance property PATCH[2/5] Fixes test failure in qtest/numa-test/aarch64_numa_cpu() PATCH[3/5] Uses SMP configuration to populate CPU topology PATCH[4/5] Fixes the broken CPU topology by considering the socket boundary when the default NUMA node ID is given PATCH[5/5] Uses the populated CPU topology to build PPTT table, instead of calculate it again Changelog ========= v8: * Separate PATCH[v8 2/5] to fix test failure in qtest/ numa-test/aarch64_numa_cpu() (Igor) * Improvents to coding style, changelog and comments (Yanan) v6/v7: * Fixed description for 'cluster-id' and 'core-id' (Yanan) * Remove '% ms->smp.sockets' in socket ID calculation (Yanan) * Fixed tests/qtest/numa-test/aarch64_numa_cpu() (Yanan) * Initialized offset variables in build_pptt() (Jonathan) * Added comments about the expected and sorted layout of cpus[n].props.*_id and assert() on the exceptional cases (Igor) v4/v5: * Split PATCH[v3 1/3] to PATCH[v5 1/4] and PATCH[v5 2/4]. Verify or dump 'clsuter-id' in various spots (Yanan) * s/within cluster/within cluster\/die/ for 'core-id' in qapi/machine.json (Igor) * Apply '% ms->smp.{sockets, clusters, cores, threads} in virt_possible_cpu_arch_ids() as x86 does (Igor) * Use [0 - possible_cpus->len] as ACPI processor UID to build PPTT table and PATCH[v3 4/4] is dropped (Igor) * Simplified build_pptt() to add all entries in one loop on ms->possible_cpus (Igor) v3: * Split PATCH[v2 1/3] to PATCH[v3 1/4] and PATCH[v3 2/4] (Yanan) * Don't take account of die ID in CPU topology population and added assert(!mc->smp_props.dies_supported) (Yanan/Igor) * Assign cluster_id and use it when building PPTT table (Yanan/Igor) v2: * Populate the CPU topology in virt_possible_cpu_arch_ids() so that it can be reused in virt_get_default_cpu_node_id() (Igor) * Added PATCH[2/3] to use the existing CPU topology when the PPTT table is built (Igor) * Added PATCH[3/3] to take thread ID as ACPI processor ID in MADT and SRAT table (Gavin) Gavin Shan (5): qapi/machine.json: Add cluster-id qtest/numa-test: Specify CPU topology in aarch64_numa_cpu() hw/arm/virt: Consider SMP configuration in CPU topology hw/arm/virt: Fix CPU's default NUMA node ID hw/acpi/aml-build: Use existing CPU topology to build PPTT table hw/acpi/aml-build.c | 111 ++++++++++++++++--------------------- hw/arm/virt.c | 19 ++++++- hw/core/machine-hmp-cmds.c | 4 ++ hw/core/machine.c | 16 ++++++ qapi/machine.json | 6 +- tests/qtest/numa-test.c | 3 +- 6 files changed, 91 insertions(+), 68 deletions(-)