mbox series

[v2,net-next,0/2] ip_gre, ip6_gre: Make [IP6]GRE[TAP] devices always NETIF_F_LLTX

Message ID cover.1651207788.git.peilin.ye@bytedance.com (mailing list archive)
Headers show
Series ip_gre, ip6_gre: Make [IP6]GRE[TAP] devices always NETIF_F_LLTX | expand

Message

Peilin Ye April 29, 2022, 5:24 a.m. UTC
From: Peilin Ye <peilin.ye@bytedance.com>

v1: https://lore.kernel.org/netdev/cover.1650580763.git.peilin.ye@bytedance.com/

change since v1:
  - deleted "depends on patch..." in [1/2]'s commit message

Hi all,

This patchset depends on these fixes [1], which has been merged into
net-next.  Since o_seqno is now atomic_t, we can always turn on
NETIF_F_LLTX for [IP6]GRE[TAP] devices, since we no longer need the TX
lock (&txq->_xmit_lock).

We could probably do the same thing to [IP6]ERSPAN devices as well, but
I'm not familiar with them yet.  For example, ERSPAN devices are
initialized as |= GRE_FEATURES in erspan_tunnel_init(), but I don't see
IP6ERSPAN devices being initialized as |= GRE6_FEATURES.  Where should we
initialize IP6ERSPAN devices' ->features?  Please suggest if I'm missing
something, thanks!

[1] https://lore.kernel.org/netdev/cover.1650575919.git.peilin.ye@bytedance.com/

Thanks,
Peilin Ye (2):
  ip_gre: Make GRE and GRETAP devices always NETIF_F_LLTX
  ip6_gre: Make IP6GRE and IP6GRETAP devices always NETIF_F_LLTX

 net/ipv4/ip_gre.c  | 50 ++++++++++++++++++++--------------------------
 net/ipv6/ip6_gre.c | 34 ++++++++++++-------------------
 2 files changed, 35 insertions(+), 49 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 2, 2022, 8:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 28 Apr 2022 22:24:17 -0700 you wrote:
> From: Peilin Ye <peilin.ye@bytedance.com>
> 
> v1: https://lore.kernel.org/netdev/cover.1650580763.git.peilin.ye@bytedance.com/
> 
> change since v1:
>   - deleted "depends on patch..." in [1/2]'s commit message
> 
> [...]

Here is the summary with links:
  - [v2,net-next,1/2] ip_gre: Make GRE and GRETAP devices always NETIF_F_LLTX
    https://git.kernel.org/netdev/net-next/c/020e8f60aa8b
  - [v2,net-next,2/2] ip6_gre: Make IP6GRE and IP6GRETAP devices always NETIF_F_LLTX
    https://git.kernel.org/netdev/net-next/c/b11ebf2ca2c1

You are awesome, thank you!