| Message ID | 20220502084830.285639-1-javierm@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: Allow simpledrm to setup its emulated FB as firmware provided | expand |
Hi Javier Am 02.05.22 um 10:48 schrieb Javier Martinez Canillas: > Hello, > > This series contain patches suggested by Thomas Zimmermannas a feedback for > "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and > drivers probe" [0]. > > Since other changes in [0] were more controversial, I decided to just split > this part in a new patch-set and revisit the rest of the patches later. > > Patch #1 is just a cleanup since when working on this noticed that some DRM > drivers were passing as preferred bits per pixel to drm_fbdev_generic_setup() > the value that is the default anyways. > > Patch #2 renames the 'preferred_bpp' drm_fbdev_generic_setup() parameter to > 'options', and make this a multi field parameter so that it can be extended > later to pass other options as well. > > Patch #3 finally adds the new DRM_FB_FW option and makes simpledrm to use it > so that the registered framebuffer device is also marked as firmware provided. For the whole patchset: Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Thanks a lot! > > [0]: https://lore.kernel.org/lkml/20220429084253.1085911-1-javierm@redhat.com/ > > > Javier Martinez Canillas (3): > drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() > drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() > parameter > drm: Allow simpledrm to setup its emulated FB as firmware provided > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++-- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- > drivers/gpu/drm/ast/ast_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_drv.c | 2 +- > drivers/gpu/drm/drm_fb_helper.c | 25 ++++++++++++++++--- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- > .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > drivers/gpu/drm/mcde/mcde_drv.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/sti/sti_drv.c | 2 +- > drivers/gpu/drm/stm/drv.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- > drivers/gpu/drm/tidss/tidss_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/tiny/arcpgu.c | 2 +- > drivers/gpu/drm/tiny/bochs.c | 2 +- > drivers/gpu/drm/tiny/cirrus.c | 2 +- > drivers/gpu/drm/tiny/simpledrm.c | 2 +- > drivers/gpu/drm/tve200/tve200_drv.c | 2 +- > drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 +- > include/drm/drm_fb_helper.h | 22 ++++++++++++++++ > 36 files changed, 80 insertions(+), 39 deletions(-) >
Hello Thomas, On 5/2/22 12:35, Thomas Zimmermann wrote: > Hi Javier > > Am 02.05.22 um 10:48 schrieb Javier Martinez Canillas: >> Hello, >> >> This series contain patches suggested by Thomas Zimmermannas a feedback for Ups, I missed a space here. I meant to write "Zimmermann as a feedback..." >> "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and >> drivers probe" [0]. >> >> Since other changes in [0] were more controversial, I decided to just split >> this part in a new patch-set and revisit the rest of the patches later. >> >> Patch #1 is just a cleanup since when working on this noticed that some DRM >> drivers were passing as preferred bits per pixel to drm_fbdev_generic_setup() >> the value that is the default anyways. >> >> Patch #2 renames the 'preferred_bpp' drm_fbdev_generic_setup() parameter to >> 'options', and make this a multi field parameter so that it can be extended >> later to pass other options as well. >> >> Patch #3 finally adds the new DRM_FB_FW option and makes simpledrm to use it >> so that the registered framebuffer device is also marked as firmware provided. > > For the whole patchset: > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > > Thanks a lot! > Thanks for the prompt review!
Hello, This series contain patches suggested by Thomas Zimmermannas a feedback for "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe" [0]. Since other changes in [0] were more controversial, I decided to just split this part in a new patch-set and revisit the rest of the patches later. Patch #1 is just a cleanup since when working on this noticed that some DRM drivers were passing as preferred bits per pixel to drm_fbdev_generic_setup() the value that is the default anyways. Patch #2 renames the 'preferred_bpp' drm_fbdev_generic_setup() parameter to 'options', and make this a multi field parameter so that it can be extended later to pass other options as well. Patch #3 finally adds the new DRM_FB_FW option and makes simpledrm to use it so that the registered framebuffer device is also marked as firmware provided. [0]: https://lore.kernel.org/lkml/20220429084253.1085911-1-javierm@redhat.com/ Javier Martinez Canillas (3): drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter drm: Allow simpledrm to setup its emulated FB as firmware provided drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++-- drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- drivers/gpu/drm/arm/malidp_drv.c | 2 +- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- drivers/gpu/drm/ast/ast_drv.c | 2 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- drivers/gpu/drm/drm_drv.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 25 ++++++++++++++++--- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- drivers/gpu/drm/mcde/mcde_drv.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- drivers/gpu/drm/qxl/qxl_drv.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu/drm/sti/sti_drv.c | 2 +- drivers/gpu/drm/stm/drv.c | 2 +- drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- drivers/gpu/drm/tidss/tidss_drv.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- drivers/gpu/drm/tiny/arcpgu.c | 2 +- drivers/gpu/drm/tiny/bochs.c | 2 +- drivers/gpu/drm/tiny/cirrus.c | 2 +- drivers/gpu/drm/tiny/simpledrm.c | 2 +- drivers/gpu/drm/tve200/tve200_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- drivers/gpu/drm/vc4/vc4_drv.c | 2 +- drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 +- include/drm/drm_fb_helper.h | 22 ++++++++++++++++ 36 files changed, 80 insertions(+), 39 deletions(-)