| Message ID | 20220428030534.3220410-2-aahringo@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | net: 6lowpan: simplify lookup by nhc id | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/subjectprefix | fail | "Bluetooth: " is not specified in the subject |
| tedd_an/buildkernel | success | Build Kernel PASS |
| tedd_an/buildkernel32 | success | Build Kernel32 PASS |
| tedd_an/incremental_build | success | Pass |
| tedd_an/testrunnersetup | success | Test Runner Setup PASS |
| tedd_an/testrunnerl2cap-tester | success | Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerbnep-tester | success | Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermgmt-tester | success | Total: 493, Passed: 493 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerrfcomm-tester | success | Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersco-tester | success | Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersmp-tester | success | Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneruserchan-tester | success | Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0 |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=636426 ---Test result--- Test Summary: CheckPatch PASS 5.77 seconds GitLint PASS 1.40 seconds SubjectPrefix FAIL 0.92 seconds BuildKernel PASS 41.46 seconds BuildKernel32 PASS 37.48 seconds Incremental Build with patchesPASS 63.86 seconds TestRunner: Setup PASS 646.14 seconds TestRunner: l2cap-tester PASS 20.96 seconds TestRunner: bnep-tester PASS 7.82 seconds TestRunner: mgmt-tester PASS 130.76 seconds TestRunner: rfcomm-tester PASS 12.14 seconds TestRunner: sco-tester PASS 11.49 seconds TestRunner: smp-tester PASS 11.45 seconds TestRunner: userchan-tester PASS 7.68 seconds Details ############################## Test: SubjectPrefix - FAIL - 0.92 seconds Check subject contains "Bluetooth" prefix "Bluetooth: " is not specified in the subject "Bluetooth: " is not specified in the subject "Bluetooth: " is not specified in the subject --- Regards, Linux Bluetooth
Hello. On 28.04.22 05:05, Alexander Aring wrote: > The keyword const makes no sense for scalar types inside the lowpan_nhc > structure. Most compilers will ignore it so we remove the keyword from > the scalar types. > > Signed-off-by: Alexander Aring <aahringo@redhat.com> > --- > net/6lowpan/nhc.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h > index 67951c40734b..2ac7da388c4d 100644 > --- a/net/6lowpan/nhc.h > +++ b/net/6lowpan/nhc.h > @@ -67,11 +67,11 @@ module_exit(__nhc##_exit); > struct lowpan_nhc { > struct rb_node node; > const char *name; > - const u8 nexthdr; > - const size_t nexthdrlen; > + u8 nexthdr; > + size_t nexthdrlen; > u8 *id; > u8 *idmask; > - const size_t idlen; > + size_t idlen; > > void (*idsetup)(struct lowpan_nhc *nhc); > int (*uncompress)(struct sk_buff *skb, size_t needed); Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> regards Stefan Schmidt
On Wed, 2022-04-27 at 23:05 -0400, Alexander Aring wrote: > The keyword const makes no sense for scalar types inside the > lowpan_nhc > structure. Most compilers will ignore it so we remove the keyword > from > the scalar types. > > Signed-off-by: Alexander Aring <aahringo@redhat.com> > --- > net/6lowpan/nhc.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h > index 67951c40734b..2ac7da388c4d 100644 > --- a/net/6lowpan/nhc.h > +++ b/net/6lowpan/nhc.h > @@ -67,11 +67,11 @@ module_exit(__nhc##_exit); > struct lowpan_nhc { > struct rb_node node; > const char *name; > - const u8 nexthdr; > - const size_t nexthdrlen; > + u8 nexthdr; > + size_t nexthdrlen; > u8 *id; > u8 *idmask; > - const size_t idlen; > + size_t idlen; > > void (*idsetup)(struct lowpan_nhc *nhc); > int (*uncompress)(struct sk_buff *skb, size_t > needed); Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> Cheers, Jukka
diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h index 67951c40734b..2ac7da388c4d 100644 --- a/net/6lowpan/nhc.h +++ b/net/6lowpan/nhc.h @@ -67,11 +67,11 @@ module_exit(__nhc##_exit); struct lowpan_nhc { struct rb_node node; const char *name; - const u8 nexthdr; - const size_t nexthdrlen; + u8 nexthdr; + size_t nexthdrlen; u8 *id; u8 *idmask; - const size_t idlen; + size_t idlen; void (*idsetup)(struct lowpan_nhc *nhc); int (*uncompress)(struct sk_buff *skb, size_t needed);
The keyword const makes no sense for scalar types inside the lowpan_nhc structure. Most compilers will ignore it so we remove the keyword from the scalar types. Signed-off-by: Alexander Aring <aahringo@redhat.com> --- net/6lowpan/nhc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)