| Message ID | 20220502204050.88316-5-nick.hawkins@hpe.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce HPE GXP Architecture | expand |
On 02/05/2022 22:40, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Add support for the HPE GXP Timer and Watchdog. There are multiple > timers on the SoC but only one is enabled at this time. > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > > --- > v6: > * Removed simple-mfd compatible, timer will create watchdog without > watchdog node. > * Removed timer0 label > * Changed title from HPE GXP TIMER to HPE GXP Timer > * Changed clock name iopclk to iop > * Set additionalProperties to false > * Added space after ',' in the compatible list > * Changed subject to match the log better The subject after prefixes does not match it better. What is "creation"? "Add HPE GXP Timer and Watchdog" Rest is okay, so this could be fixed while applying (if you are going to resend, don't loose that comment and don't loose the tag): Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 02 May 2022 15:40:47 -0500, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Add support for the HPE GXP Timer and Watchdog. There are multiple > timers on the SoC but only one is enabled at this time. > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > > --- > v6: > * Removed simple-mfd compatible, timer will create watchdog without > watchdog node. > * Removed timer0 label > * Changed title from HPE GXP TIMER to HPE GXP Timer > * Changed clock name iopclk to iop > * Set additionalProperties to false > * Added space after ',' in the compatible list > * Changed subject to match the log better > * Altered description to take up 75 characters per line > * Changed description to better describe the patch > v5: > * Fix versioning > * Fixed typo time -> timer > v4: > * Made watchdog a child of timer > * Added reference clock > v3: > * Removed maintainer change from patch > * Verified there was no compilation errors > * Added reference code in separate patch of patchset > v2: > * Converted from txt to yaml > --- > .../bindings/timer/hpe,gxp-timer.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/hpe,gxp-timer.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/timer/hpe,gxp-timer.yaml b/Documentation/devicetree/bindings/timer/hpe,gxp-timer.yaml new file mode 100644 index 000000000000..d33d90f44d28 --- /dev/null +++ b/Documentation/devicetree/bindings/timer/hpe,gxp-timer.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/hpe,gxp-timer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HPE GXP Timer + +maintainers: + - Nick Hawkins <nick.hawkins@hpe.com> + - Jean-Marie Verdun <verdun@hpe.com> + +properties: + compatible: + const: hpe,gxp-timer + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: iop + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + timer@c0000000 { + compatible = "hpe,gxp-timer"; + reg = <0x80 0x16>; + interrupts = <0>; + interrupt-parent = <&vic0>; + clocks = <&iopclk>; + clock-names = "iop"; + };