diff mbox series

[2/2] dt-bindings: mmc: brcm,sdhci-brcmstb: cleanup example

Message ID 20220428081817.35382-2-krzysztof.kozlowski@linaro.org (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: mmc: brcm,sdhci-brcmstb: correct number of reg entries | expand

Commit Message

Krzysztof Kozlowski April 28, 2022, 8:18 a.m. UTC
Cleanup indentation and order of entries in example DTS.  The most
important when reading the DTS are compatible and reg.  By convention
they are usually to first entries.  No functional change.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/mmc/brcm,sdhci-brcmstb.yaml       | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

Florian Fainelli April 28, 2022, 3 p.m. UTC | #1
On 4/28/2022 1:18 AM, Krzysztof Kozlowski wrote:
> Cleanup indentation and order of entries in example DTS.  The most
> important when reading the DTS are compatible and reg.  By convention
> they are usually to first entries.  No functional change.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Ulf Hansson May 4, 2022, 10:37 a.m. UTC | #2
On Thu, 28 Apr 2022 at 10:18, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Cleanup indentation and order of entries in example DTS.  The most
> important when reading the DTS are compatible and reg.  By convention
> they are usually to first entries.  No functional change.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  .../bindings/mmc/brcm,sdhci-brcmstb.yaml       | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> index 54a0edab5f8c..b672202fff4e 100644
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -65,15 +65,15 @@ unevaluatedProperties: false
>  examples:
>    - |
>      mmc@84b0000 {
> -      sd-uhs-sdr50;
> -      sd-uhs-ddr50;
> -      sd-uhs-sdr104;
> -      sdhci,auto-cmd12;
>        compatible = "brcm,bcm7216-sdhci",
>                     "brcm,bcm7445-sdhci",
>                     "brcm,sdhci-brcmstb";
>        reg = <0x84b0000 0x260>, <0x84b0300 0x200>;
>        reg-names = "host", "cfg";
> +      sd-uhs-sdr50;
> +      sd-uhs-ddr50;
> +      sd-uhs-sdr104;
> +      sdhci,auto-cmd12;
>        interrupts = <0x0 0x26 0x4>;
>        interrupt-names = "sdio0_0";
>        clocks = <&scmi_clk 245>;
> @@ -81,6 +81,11 @@ examples:
>      };
>
>      mmc@84b1000 {
> +      compatible = "brcm,bcm7216-sdhci",
> +                   "brcm,bcm7445-sdhci",
> +                   "brcm,sdhci-brcmstb";
> +      reg = <0x84b1000 0x260>, <0x84b1300 0x200>;
> +      reg-names = "host", "cfg";
>        mmc-ddr-1_8v;
>        mmc-hs200-1_8v;
>        mmc-hs400-1_8v;
> @@ -88,11 +93,6 @@ examples:
>        supports-cqe;
>        non-removable;
>        bus-width = <0x8>;
> -      compatible = "brcm,bcm7216-sdhci",
> -           "brcm,bcm7445-sdhci",
> -            "brcm,sdhci-brcmstb";
> -      reg = <0x84b1000 0x260>, <0x84b1300 0x200>;
> -      reg-names = "host", "cfg";
>        interrupts = <0x0 0x27 0x4>;
>        interrupt-names = "sdio1_0";
>        clocks = <&scmi_clk 245>;
> --
> 2.32.0
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
index 54a0edab5f8c..b672202fff4e 100644
--- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
+++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
@@ -65,15 +65,15 @@  unevaluatedProperties: false
 examples:
   - |
     mmc@84b0000 {
-      sd-uhs-sdr50;
-      sd-uhs-ddr50;
-      sd-uhs-sdr104;
-      sdhci,auto-cmd12;
       compatible = "brcm,bcm7216-sdhci",
                    "brcm,bcm7445-sdhci",
                    "brcm,sdhci-brcmstb";
       reg = <0x84b0000 0x260>, <0x84b0300 0x200>;
       reg-names = "host", "cfg";
+      sd-uhs-sdr50;
+      sd-uhs-ddr50;
+      sd-uhs-sdr104;
+      sdhci,auto-cmd12;
       interrupts = <0x0 0x26 0x4>;
       interrupt-names = "sdio0_0";
       clocks = <&scmi_clk 245>;
@@ -81,6 +81,11 @@  examples:
     };
 
     mmc@84b1000 {
+      compatible = "brcm,bcm7216-sdhci",
+                   "brcm,bcm7445-sdhci",
+                   "brcm,sdhci-brcmstb";
+      reg = <0x84b1000 0x260>, <0x84b1300 0x200>;
+      reg-names = "host", "cfg";
       mmc-ddr-1_8v;
       mmc-hs200-1_8v;
       mmc-hs400-1_8v;
@@ -88,11 +93,6 @@  examples:
       supports-cqe;
       non-removable;
       bus-width = <0x8>;
-      compatible = "brcm,bcm7216-sdhci",
-           "brcm,bcm7445-sdhci",
-            "brcm,sdhci-brcmstb";
-      reg = <0x84b1000 0x260>, <0x84b1300 0x200>;
-      reg-names = "host", "cfg";
       interrupts = <0x0 0x27 0x4>;
       interrupt-names = "sdio1_0";
       clocks = <&scmi_clk 245>;