mbox series

[for,mm-unstable,0/3] Fix build errors due to folio_test_large() misuse

Message ID 20220504200758.314478-1-sj@kernel.org (mailing list archive)
Headers show
Series Fix build errors due to folio_test_large() misuse | expand

Message

SeongJae Park May 4, 2022, 8:07 p.m. UTC 
Several commits on 'mm-unstable' replaces 'PageTransHuge()' with
'folio_test_large()' instead of 'folio_test_transhuge()'.  As a result,
several build errors occur when 'CONFIG_TRANSPARENT_HUGEPAGE' is unset.

This patchset fixes the issues by replacing the check to use
'folio_test_transhuge()'.

SeongJae Park (3):
  mm/vmscan: Use folio_test_transhuge() for THP check
  mm/shmem: Use folio_test_transhuge() for THP check
  mm/shmem: Use folio_test_transhuge() for THP check

 mm/shmem.c  | 8 ++++----
 mm/vmscan.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Matthew Wilcox May 4, 2022, 8:10 p.m. UTC | #1 
On Wed, May 04, 2022 at 08:07:55PM +0000, SeongJae Park wrote:
> Several commits on 'mm-unstable' replaces 'PageTransHuge()' with
> 'folio_test_large()' instead of 'folio_test_transhuge()'.  As a result,
> several build errors occur when 'CONFIG_TRANSPARENT_HUGEPAGE' is unset.

I sent an entire replacement patch series mere minutes ago which I think
fixes everything you mention here.  Please check?

https://lore.kernel.org/linux-mm/20220504182857.4013401-1-willy@infradead.org/T/#t
SeongJae Park May 4, 2022, 8:23 p.m. UTC | #2 
On Wed, 4 May 2022 21:10:22 +0100 Matthew Wilcox <willy@infradead.org> wrote:

> On Wed, May 04, 2022 at 08:07:55PM +0000, SeongJae Park wrote:
> > Several commits on 'mm-unstable' replaces 'PageTransHuge()' with
> > 'folio_test_large()' instead of 'folio_test_transhuge()'.  As a result,
> > several build errors occur when 'CONFIG_TRANSPARENT_HUGEPAGE' is unset.
> 
> I sent an entire replacement patch series mere minutes ago which I think
> fixes everything you mention here.  Please check?
> 
> https://lore.kernel.org/linux-mm/20220504182857.4013401-1-willy@infradead.org/T/#t

Thanks for the answer.  Yes, seems the fix has made there :)


Thanks,
SJ