| Message ID | 20220504210948.2968827-1-jiangzp@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Adding bonded flag to D-Bus property | expand |
Hi Zhengping, On Wed, May 4, 2022 at 2:09 PM Zhengping Jiang <jiangzp@google.com> wrote: > > Currently BlueZ client can't know easily whether a device is bonded or > not. This is causing issues for a number of applications. For example, > in the Nearby Share case, the peer device is paired, but not bonded. > This series will add the "Bonded" property in org.bluez.Device1 D-Bus > interface. Changes are also made in bluetoothctl to show the status of > the bonded flag as well as a list of bonded devices. > > Changes in v3: > - Move documentation update to a separate patch > - Add description to bonded and paired > - Add an optional argument to the devices command to filter device list > - Remove paired-devices command > > Changes in v2: > - Move one variable declaration to the top following C90 standard > > Changes in v1: > - Add "Bonded" to D-Bus interface > - Send property changed signal if the bonded flag is changed > - Show the status of the "Bonded" flag in bluetoothctl > - Add option to show list of bonded devices > > Zhengping Jiang (3): > device: Add "Bonded" flag to dbus property > doc: add "Bonded" flag to dbus property > client: Add filter to devices and show Bonded in info > > client/main.c | 72 ++++++++++++++++++++++++++++++---------------- > doc/device-api.txt | 12 +++++++- > src/device.c | 38 ++++++++++++++++++++---- > 3 files changed, 91 insertions(+), 31 deletions(-) > > -- > 2.36.0.464.gb9c8b46e94-goog src/device.c: In function ‘device_set_bonded’: src/device.c:6141:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 6141 | struct bearer_state *state = get_state(device, bdaddr_type); |
Hi Zhengping, On Wed, May 4, 2022 at 2:54 PM Zhengping Jiang <jiangzp@google.com> wrote: > > Hi Luiz, > > Sorry for the error. It should have been fixed in patch 2. I think I updated the wrong version. Don't worry, I'm fixing it myself. > Thanks, > Zhengping > > On Wed, May 4, 2022 at 2:49 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: >> >> Hi Zhengping, >> >> On Wed, May 4, 2022 at 2:09 PM Zhengping Jiang <jiangzp@google.com> wrote: >> > >> > Currently BlueZ client can't know easily whether a device is bonded or >> > not. This is causing issues for a number of applications. For example, >> > in the Nearby Share case, the peer device is paired, but not bonded. >> > This series will add the "Bonded" property in org.bluez.Device1 D-Bus >> > interface. Changes are also made in bluetoothctl to show the status of >> > the bonded flag as well as a list of bonded devices. >> > >> > Changes in v3: >> > - Move documentation update to a separate patch >> > - Add description to bonded and paired >> > - Add an optional argument to the devices command to filter device list >> > - Remove paired-devices command >> > >> > Changes in v2: >> > - Move one variable declaration to the top following C90 standard >> > >> > Changes in v1: >> > - Add "Bonded" to D-Bus interface >> > - Send property changed signal if the bonded flag is changed >> > - Show the status of the "Bonded" flag in bluetoothctl >> > - Add option to show list of bonded devices >> > >> > Zhengping Jiang (3): >> > device: Add "Bonded" flag to dbus property >> > doc: add "Bonded" flag to dbus property >> > client: Add filter to devices and show Bonded in info >> > >> > client/main.c | 72 ++++++++++++++++++++++++++++++---------------- >> > doc/device-api.txt | 12 +++++++- >> > src/device.c | 38 ++++++++++++++++++++---- >> > 3 files changed, 91 insertions(+), 31 deletions(-) >> > >> > -- >> > 2.36.0.464.gb9c8b46e94-goog >> >> src/device.c: In function ‘device_set_bonded’: >> src/device.c:6141:9: error: ISO C90 forbids mixed declarations and >> code [-Werror=declaration-after-statement] >> 6141 | struct bearer_state *state = get_state(device, bdaddr_type); >> | >> >> >> -- >> Luiz Augusto von Dentz
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 4 May 2022 14:09:45 -0700 you wrote: > Currently BlueZ client can't know easily whether a device is bonded or > not. This is causing issues for a number of applications. For example, > in the Nearby Share case, the peer device is paired, but not bonded. > This series will add the "Bonded" property in org.bluez.Device1 D-Bus > interface. Changes are also made in bluetoothctl to show the status of > the bonded flag as well as a list of bonded devices. > > [...] Here is the summary with links: - [Bluez,v3,1/3] device: Add "Bonded" flag to dbus property (no matching commit) - [Bluez,v3,2/3] doc: add "Bonded" flag to dbus property https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5c05df7c7607 - [Bluez,v3,3/3] client: Add filter to devices and show Bonded in info https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=bda2a9e6f902 You are awesome, thank you!