mbox series

[0/2] Upgrade mingw base packages

Message ID 20220503200524.1868-1-luoyonggang@gmail.com (mailing list archive)
Headers show
Series Upgrade mingw base packages | expand

Message

Yonggang Luo May 3, 2022, 8:05 p.m. UTC
v1. upgrade both cirrus and gitlab-ci to the newest mingw base release

Yonggang Luo (2):
  cirrus/win32: upgrade mingw base packages
  gitlab-ci: Upgrade mingw base package.

 .cirrus.yml              | 2 +-
 .gitlab-ci.d/windows.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Marc-André Lureau May 4, 2022, 7:41 a.m. UTC | #1
Hi

On Wed, May 4, 2022 at 1:19 AM Yonggang Luo <luoyonggang@gmail.com> wrote:

> v1. upgrade both cirrus and gitlab-ci to the newest mingw base release
>
> Yonggang Luo (2):
>   cirrus/win32: upgrade mingw base packages
>   gitlab-ci: Upgrade mingw base package.
>

lgtm,
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

It would help though to have some rationale for the change. Unfortunately,
the installer news/changelog leaves a lot to be desired:
https://github.com/msys2/msys2-installer/releases.
Thomas Huth May 5, 2022, 6:29 a.m. UTC | #2
On 03/05/2022 22.05, Yonggang Luo wrote:
> v1. upgrade both cirrus and gitlab-ci to the newest mingw base release
> 
> Yonggang Luo (2):
>    cirrus/win32: upgrade mingw base packages
>    gitlab-ci: Upgrade mingw base package.
> 
>   .cirrus.yml              | 2 +-
>   .gitlab-ci.d/windows.yml | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 

Tested-by: Thomas Huth <thuth@redhat.com>

I can take this through my next misc/testing pull request if nobody else 
wants to take it first.
Alex Bennée May 5, 2022, 9:19 a.m. UTC | #3
Thomas Huth <thuth@redhat.com> writes:

> On 03/05/2022 22.05, Yonggang Luo wrote:
>> v1. upgrade both cirrus and gitlab-ci to the newest mingw base release
>> Yonggang Luo (2):
>>    cirrus/win32: upgrade mingw base packages
>>    gitlab-ci: Upgrade mingw base package.
>>   .cirrus.yml              | 2 +-
>>   .gitlab-ci.d/windows.yml | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>> 
>
> Tested-by: Thomas Huth <thuth@redhat.com>
>
> I can take this through my next misc/testing pull request if nobody
> else wants to take it first.

Go for it, I don't have any testing/next brewing at the moment.