mbox series

[v2,0/2] chrome: Remove Custom ABI |location| attribute

Message ID 20220427190804.961697-1-gwendal@chromium.org (mailing list archive)
Headers show
Series chrome: Remove Custom ABI |location| attribute | expand

Message

Gwendal Grignou April 27, 2022, 7:08 p.m. UTC 
Instead of using the custom |location| attribute, use the |label| attribute
introduced in kernel 5.8.
A new location is required for sensors located in a camera subassembly that
swivels.

---
 changes in v2:
 * Add "accel-camera" define.
 * remove |location| attribute completely.

Gwendal Grignou (2):
  iio: ABI: Add a new location label
  iio: common: cros_ec_sensors: Add label attribute

 Documentation/ABI/testing/sysfs-bus-iio       |  5 ++++
 drivers/iio/accel/cros_ec_accel_legacy.c      |  2 +-
 .../cros_ec_sensors/cros_ec_sensors_core.c    | 30 ++++++-------------
 drivers/iio/light/cros_ec_light_prox.c        |  2 --
 drivers/iio/pressure/cros_ec_baro.c           |  2 --
 .../linux/iio/common/cros_ec_sensors_core.h   |  2 --
 6 files changed, 15 insertions(+), 28 deletions(-)

Comments

Jonathan Cameron April 28, 2022, 8:31 a.m. UTC | #1 
On Wed, 27 Apr 2022 12:08:02 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:

> Instead of using the custom |location| attribute, use the |label| attribute
> introduced in kernel 5.8.
> A new location is required for sensors located in a camera subassembly that
> swivels.
> 

I'm assuming this ABI change is fine because you can change the software stack
as well?

Is this likely to break anyone relying on the old location attribute?

Jonathan

> ---
>  changes in v2:
>  * Add "accel-camera" define.
>  * remove |location| attribute completely.
> 
> Gwendal Grignou (2):
>   iio: ABI: Add a new location label
>   iio: common: cros_ec_sensors: Add label attribute
> 
>  Documentation/ABI/testing/sysfs-bus-iio       |  5 ++++
>  drivers/iio/accel/cros_ec_accel_legacy.c      |  2 +-
>  .../cros_ec_sensors/cros_ec_sensors_core.c    | 30 ++++++-------------
>  drivers/iio/light/cros_ec_light_prox.c        |  2 --
>  drivers/iio/pressure/cros_ec_baro.c           |  2 --
>  .../linux/iio/common/cros_ec_sensors_core.h   |  2 --
>  6 files changed, 15 insertions(+), 28 deletions(-)
>
Jonathan Cameron May 8, 2022, 6:05 p.m. UTC | #2 
On Thu, 28 Apr 2022 09:31:30 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Wed, 27 Apr 2022 12:08:02 -0700
> Gwendal Grignou <gwendal@chromium.org> wrote:
> 
> > Instead of using the custom |location| attribute, use the |label| attribute
> > introduced in kernel 5.8.
> > A new location is required for sensors located in a camera subassembly that
> > swivels.
> >   
> 
> I'm assuming this ABI change is fine because you can change the software stack
> as well?
> 
> Is this likely to break anyone relying on the old location attribute?
> 
> Jonathan
> 
Reply was off list for some reason.  Anyhow, upshot is that this is fine
so applied to the togreg branch of iio.git and pushed out as testing
for 0-day to poke at it.

Thanks,

Jonathan

> > ---
> >  changes in v2:
> >  * Add "accel-camera" define.
> >  * remove |location| attribute completely.
> > 
> > Gwendal Grignou (2):
> >   iio: ABI: Add a new location label
> >   iio: common: cros_ec_sensors: Add label attribute
> > 
> >  Documentation/ABI/testing/sysfs-bus-iio       |  5 ++++
> >  drivers/iio/accel/cros_ec_accel_legacy.c      |  2 +-
> >  .../cros_ec_sensors/cros_ec_sensors_core.c    | 30 ++++++-------------
> >  drivers/iio/light/cros_ec_light_prox.c        |  2 --
> >  drivers/iio/pressure/cros_ec_baro.c           |  2 --
> >  .../linux/iio/common/cros_ec_sensors_core.h   |  2 --
> >  6 files changed, 15 insertions(+), 28 deletions(-)
> >   
>