diff mbox series

dt-bindings: clock: stm32mp1: adapt example for "st, stm32mp1-rcc-secure"

Message ID 20220509134658.16267-1-alexandre.torgue@foss.st.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: clock: stm32mp1: adapt example for "st, stm32mp1-rcc-secure" | expand

Commit Message

Alexandre TORGUE May 9, 2022, 1:46 p.m. UTC 
For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
required properties.

Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>

Comments

Rob Herring (Arm) May 9, 2022, 7:16 p.m. UTC | #1 
On Mon, 09 May 2022 15:46:58 +0200, Alexandre Torgue wrote:
> For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
> required properties.
> 
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts:27.33-34 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1401: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Alexandre TORGUE May 10, 2022, 7:47 a.m. UTC | #2 
Hi Rob

On 5/9/22 21:16, Rob Herring wrote:
> On Mon, 09 May 2022 15:46:58 +0200, Alexandre Torgue wrote:
>> For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
>> required properties.
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts:27.33-34 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1401: dt_binding_check] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 

I just updated dtschema and yamllint seems to be well installed. I don't 
see the see above. I wrote this patch on top of my stm32-next tree. Do I 
have to send it directly to arm-soc in order to be merged on top of my 
latest pull-request ?

Alex
Rob Herring (Arm) May 10, 2022, 2:57 p.m. UTC | #3 
On Tue, May 10, 2022 at 09:47:05AM +0200, Alexandre TORGUE wrote:
> Hi Rob
> 
> On 5/9/22 21:16, Rob Herring wrote:
> > On Mon, 09 May 2022 15:46:58 +0200, Alexandre Torgue wrote:
> > > For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
> > > required properties.
> > > 
> > > Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > Error: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts:27.33-34 syntax error
> > FATAL ERROR: Unable to parse input tree
> > make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [Makefile:1401: dt_binding_check] Error 2
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/patch/
> > 
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> > 
> 
> I just updated dtschema and yamllint seems to be well installed. I don't see
> the see above. I wrote this patch on top of my stm32-next tree. Do I have to
> send it directly to arm-soc in order to be merged on top of my latest
> pull-request ?

That appears to be header related AFAICT. Maybe you have header changes 
in your tree. The issue this is fixing is in your tree, so it should be 
applied there.

Rob
Alexandre TORGUE May 10, 2022, 4:44 p.m. UTC | #4 
Hi Rob

On 5/10/22 16:57, Rob Herring wrote:
> On Tue, May 10, 2022 at 09:47:05AM +0200, Alexandre TORGUE wrote:
>> Hi Rob
>>
>> On 5/9/22 21:16, Rob Herring wrote:
>>> On Mon, 09 May 2022 15:46:58 +0200, Alexandre Torgue wrote:
>>>> For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
>>>> required properties.
>>>>
>>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>>>
>>>
>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> Error: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts:27.33-34 syntax error
>>> FATAL ERROR: Unable to parse input tree
>>> make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [Makefile:1401: dt_binding_check] Error 2
>>>
>>> doc reference errors (make refcheckdocs):
>>>
>>> See https://patchwork.ozlabs.org/patch/
>>>
>>> This check can fail if there are any dependencies. The base for a patch
>>> series is generally the most recent rc1.
>>>
>>> If you already ran 'make dt_binding_check' and didn't see the above
>>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>>> date:
>>>
>>> pip3 install dtschema --upgrade
>>>
>>> Please check and re-submit.
>>>
>>
>> I just updated dtschema and yamllint seems to be well installed. I don't see
>> the see above. I wrote this patch on top of my stm32-next tree. Do I have to
>> send it directly to arm-soc in order to be merged on top of my latest
>> pull-request ?
> 
> That appears to be header related AFAICT. Maybe you have header changes
> in your tree. The issue this is fixing is in your tree, so it should be
> applied there.

Ah yes! CK_SCMIxxx have changed in my tree (merged in arm-soc tree) and 
this patch is done on top of this change. So has to be applied in arm-soc.
So I just have to send it directly to Arnd and arm-soc ?

Alex


> 
> Rob
Rob Herring (Arm) May 10, 2022, 6:22 p.m. UTC | #5 
On Tue, May 10, 2022 at 06:44:19PM +0200, Alexandre TORGUE wrote:
> Hi Rob
> 
> On 5/10/22 16:57, Rob Herring wrote:
> > On Tue, May 10, 2022 at 09:47:05AM +0200, Alexandre TORGUE wrote:
> > > Hi Rob
> > > 
> > > On 5/9/22 21:16, Rob Herring wrote:
> > > > On Mon, 09 May 2022 15:46:58 +0200, Alexandre Torgue wrote:
> > > > > For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
> > > > > required properties.
> > > > > 
> > > > > Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> > > > > 
> > > > 
> > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > > 
> > > > yamllint warnings/errors:
> > > > 
> > > > dtschema/dtc warnings/errors:
> > > > Error: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts:27.33-34 syntax error
> > > > FATAL ERROR: Unable to parse input tree
> > > > make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb] Error 1
> > > > make[1]: *** Waiting for unfinished jobs....
> > > > make: *** [Makefile:1401: dt_binding_check] Error 2
> > > > 
> > > > doc reference errors (make refcheckdocs):
> > > > 
> > > > See https://patchwork.ozlabs.org/patch/
> > > > 
> > > > This check can fail if there are any dependencies. The base for a patch
> > > > series is generally the most recent rc1.
> > > > 
> > > > If you already ran 'make dt_binding_check' and didn't see the above
> > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > > date:
> > > > 
> > > > pip3 install dtschema --upgrade
> > > > 
> > > > Please check and re-submit.
> > > > 
> > > 
> > > I just updated dtschema and yamllint seems to be well installed. I don't see
> > > the see above. I wrote this patch on top of my stm32-next tree. Do I have to
> > > send it directly to arm-soc in order to be merged on top of my latest
> > > pull-request ?
> > 
> > That appears to be header related AFAICT. Maybe you have header changes
> > in your tree. The issue this is fixing is in your tree, so it should be
> > applied there.
> 
> Ah yes! CK_SCMIxxx have changed in my tree (merged in arm-soc tree) and this
> patch is done on top of this change. So has to be applied in arm-soc.
> So I just have to send it directly to Arnd and arm-soc ?

If you don't have a fixes branch for them (or one that will be pulled 
soonish), then yes.

Rob
Rob Herring (Arm) May 10, 2022, 6:23 p.m. UTC | #6 
On Mon, May 09, 2022 at 03:46:58PM +0200, Alexandre Torgue wrote:
> For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
> required properties.
> 
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>

Assuming this works in arm-soc tree,

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
index bb0e0b92e907..45b94124366c 100644
--- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
+++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
@@ -106,10 +106,17 @@  additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/stm32mp1-clks.h>
     rcc: rcc@50000000 {
         compatible = "st,stm32mp1-rcc-secure", "syscon";
         reg = <0x50000000 0x1000>;
         #clock-cells = <1>;
         #reset-cells = <1>;
+        clock-names = "hse", "hsi", "csi", "lse", "lsi";
+        clocks = <&scmi_clk CK_SCMI_HSE>,
+                 <&scmi_clk CK_SCMI_HSI>,
+                 <&scmi_clk CK_SCMI_CSI>,
+                 <&scmi_clk CK_SCMI_LSE>,
+                 <&scmi_clk CK_SCMI_LSI>;
     };
 ...