| Message ID | 20220511064400.63518-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fpga: Fix memory leak in build_info_create_dev | expand |
On Wed, May 11, 2022 at 10:44:00AM +0400, Miaoqian Lin wrote: > platform_device_alloc() create a platform device object. > we should call platform_device_put() in error path to > release the resource. > > Fixes: 543be3d8c999 ("fpga: add device feature list support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > drivers/fpga/dfl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index 599bb21d86af..f0b945bd975f 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -879,8 +879,10 @@ build_info_create_dev(struct build_feature_devs_info *binfo, > INIT_LIST_HEAD(&binfo->sub_features); > > fdev->id = dfl_id_alloc(type, &fdev->dev); > - if (fdev->id < 0) > + if (fdev->id < 0) { > + platform_device_put(fdev); > return fdev->id; > + } The build_info_free() will finally put the fdev, is it? Thanks Yilun > > fdev->dev.parent = &binfo->cdev->region->dev; > fdev->dev.devt = dfl_get_devt(dfl_devs[type].devt_type, fdev->id); > -- > 2.25.1
diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c index 599bb21d86af..f0b945bd975f 100644 --- a/drivers/fpga/dfl.c +++ b/drivers/fpga/dfl.c @@ -879,8 +879,10 @@ build_info_create_dev(struct build_feature_devs_info *binfo, INIT_LIST_HEAD(&binfo->sub_features); fdev->id = dfl_id_alloc(type, &fdev->dev); - if (fdev->id < 0) + if (fdev->id < 0) { + platform_device_put(fdev); return fdev->id; + } fdev->dev.parent = &binfo->cdev->region->dev; fdev->dev.devt = dfl_get_devt(dfl_devs[type].devt_type, fdev->id);
platform_device_alloc() create a platform device object. we should call platform_device_put() in error path to release the resource. Fixes: 543be3d8c999 ("fpga: add device feature list support") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/fpga/dfl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)