| Message ID | 20220510070914.2346011-2-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RK356x VOP2: Change register space names | expand |
Hi Sascha, Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> I'm not sure how the DT-people work - if they only track the devicetree list or their x+dt@kernel.org accounts or some mixture, but the patch was missing the maintainer email addresses - I've added them here now :-) . The change looks good to me and as I merged the original binding into drm-misc only some days ago, we also don't have a backwards- compat issue yet, so hopefully DT-people will think similarly . Heiko > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names >
On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 You ran the dt checks, right? This should give you a warning. The correct thing is drop minItems if there's always 2 entries. > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > -- > 2.30.2 > >
On Tue, May 10, 2022 at 04:08:02PM +0200, Heiko Stübner wrote: > Hi Sascha, > > Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and increase minItems to 2 as always both register spaces are needed. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > I'm not sure how the DT-people work - if they only track the devicetree list > or their x+dt@kernel.org accounts or some mixture, but the patch was > missing the maintainer email addresses - I've added them here now :-) . I only see what is in DT PW. Since I'm copied on almost everything that goes to the DT list, CC'ing me has almost no effect. > The change looks good to me and as I merged the original binding > into drm-misc only some days ago, we also don't have a backwards- > compat issue yet, so hopefully DT-people will think similarly . It will fail checks... I can't run them as this doesn't apply, so hopefully someone does. Or I can complain when next breaks. Rob
On Tue, May 10, 2022 at 12:15:29PM -0500, Rob Herring wrote: > On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and increase minItems to 2 as always both register spaces are needed. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > index 655d9b327f7d3..7238cdec9eb8a 100644 > > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > @@ -22,7 +22,7 @@ properties: > > - rockchip,rk3568-vop > > > > reg: > > - minItems: 1 > > + minItems: 2 > > You ran the dt checks, right? Well, almost... I did run dtbs_check, but I should have ran dt_binding_check. > This should give you a warning. The > correct thing is drop minItems if there's always 2 entries. Indeed this gives me a warning. Sascha
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 655d9b327f7d3..7238cdec9eb8a 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml @@ -22,7 +22,7 @@ properties: - rockchip,rk3568-vop reg: - minItems: 1 + minItems: 2 items: - description: Must contain one entry corresponding to the base address and length @@ -31,6 +31,11 @@ properties: Can optionally contain a second entry corresponding to the CRTC gamma LUT address. + reg-names: + items: + - const: vop + - const: gamma-lut + interrupts: maxItems: 1 description: @@ -86,6 +91,7 @@ properties: required: - compatible - reg + - reg-names - interrupts - clocks - clock-names
The VOP2 driver relies on reg-names properties, but these are not documented. Add the missing documentation, make reg-names mandatory and increase minItems to 2 as always both register spaces are needed. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)