| Message ID | 20220510042654.71152-3-sireeshkodali1@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: qcom: Fix handling of WCNSS IRQs | expand |
On Tue, May 10, 2022 at 09:56:54AM +0530, Sireesh Kodali wrote: > The smem-state properties for the pronto node were incorrectly labelled, > reading `qcom,state*` rather than `qcom,smem-state*`. Fix that, allowing > the stop state to be used. > > Fixes: 88106096cbf8 ("ARM: dts: msm8916: Add and enable wcnss node") > > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> Thanks for finding this! Reviewed-by: Stephan Gerhold <stephan@gerhold.net> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index e34963505e07..7ecd747dc624 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -1758,8 +1758,8 @@ pronto: remoteproc@a21b000 { > <&rpmpd MSM8916_VDDMX>; > power-domain-names = "cx", "mx"; > > - qcom,state = <&wcnss_smp2p_out 0>; > - qcom,state-names = "stop"; > + qcom,smem-states = <&wcnss_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > > pinctrl-names = "default"; > pinctrl-0 = <&wcnss_pin_a>; > -- > 2.36.0 >
On 10/05/2022 06:26, Sireesh Kodali wrote: > The smem-state properties for the pronto node were incorrectly labelled, > reading `qcom,state*` rather than `qcom,smem-state*`. Fix that, allowing > the stop state to be used. > > Fixes: 88106096cbf8 ("ARM: dts: msm8916: Add and enable wcnss node") > > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> No blank lines between tags, please. Best regards, Krzysztof
On Wed May 11, 2022 at 11:41 PM IST, Krzysztof Kozlowski wrote: > On 10/05/2022 06:26, Sireesh Kodali wrote: > > The smem-state properties for the pronto node were incorrectly labelled, > > reading `qcom,state*` rather than `qcom,smem-state*`. Fix that, allowing > > the stop state to be used. > > > > Fixes: 88106096cbf8 ("ARM: dts: msm8916: Add and enable wcnss node") > > > > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> > > No blank lines between tags, please. > > Best regards, > Krzysztof Will fix in v2 Thanks, Sireesh
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index e34963505e07..7ecd747dc624 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -1758,8 +1758,8 @@ pronto: remoteproc@a21b000 { <&rpmpd MSM8916_VDDMX>; power-domain-names = "cx", "mx"; - qcom,state = <&wcnss_smp2p_out 0>; - qcom,state-names = "stop"; + qcom,smem-states = <&wcnss_smp2p_out 0>; + qcom,smem-state-names = "stop"; pinctrl-names = "default"; pinctrl-0 = <&wcnss_pin_a>;
The smem-state properties for the pronto node were incorrectly labelled, reading `qcom,state*` rather than `qcom,smem-state*`. Fix that, allowing the stop state to be used. Fixes: 88106096cbf8 ("ARM: dts: msm8916: Add and enable wcnss node") Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)