diff mbox series

MIPS: tools: no need to initialise statics to 0

Message ID 20220508023146.100385-1-wangborong@cdjrlc.com (mailing list archive)
State Accepted
Commit a4fa106ee1e146a1955e81337ad95f0cc5c20592
Headers show
Series MIPS: tools: no need to initialise statics to 0 | expand

Commit Message

Jason Wang May 8, 2022, 2:31 a.m. UTC 
Static variables do not need to be initialised to 0, because compiler
will initialise all uninitialised statics to 0. Thus, remove the
unneeded initializations.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 arch/mips/boot/tools/relocs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Bogendoerfer May 12, 2022, 4:09 p.m. UTC | #1 
On Sun, May 08, 2022 at 10:31:46AM +0800, Jason Wang wrote:
> Static variables do not need to be initialised to 0, because compiler
> will initialise all uninitialised statics to 0. Thus, remove the
> unneeded initializations.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  arch/mips/boot/tools/relocs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/tools/relocs.c b/arch/mips/boot/tools/relocs.c
> index 1bf53f3524b3..02fc85f3e8ff 100644
> --- a/arch/mips/boot/tools/relocs.c
> +++ b/arch/mips/boot/tools/relocs.c
> @@ -351,7 +351,7 @@ static void read_symtabs(FILE *fp)
>  
>  static void read_relocs(FILE *fp)
>  {
> -	static unsigned long base = 0;
> +	static unsigned long base;
>  	int i, j;
>  
>  	if (!base) {
> -- 
> 2.35.1

applied to mips-next.

Thomas.
diff mbox series

Patch

diff --git a/arch/mips/boot/tools/relocs.c b/arch/mips/boot/tools/relocs.c
index 1bf53f3524b3..02fc85f3e8ff 100644
--- a/arch/mips/boot/tools/relocs.c
+++ b/arch/mips/boot/tools/relocs.c
@@ -351,7 +351,7 @@  static void read_symtabs(FILE *fp)
 
 static void read_relocs(FILE *fp)
 {
-	static unsigned long base = 0;
+	static unsigned long base;
 	int i, j;
 
 	if (!base) {