| Message ID | 20220511082109.1110043-2-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RK356x VOP2: Change register space names | expand |
Hi Rob, Krzysztof, Am Mittwoch, 11. Mai 2022, 10:21:07 CEST schrieb Sascha Hauer: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> does this look ok now? Thanks Heiko > --- > > Notes: > Changes since v1: > - Drop minItems > - Add reg-names properties to example > > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..fba45091d9092 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,6 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +30,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +90,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > @@ -104,6 +109,7 @@ examples: > vop: vop@fe040000 { > compatible = "rockchip,rk3568-vop"; > reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + reg-names = "vop", "gamma-lut"; > interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cru ACLK_VOP>, > <&cru HCLK_VOP>, >
On Wed, 11 May 2022 10:21:07 +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > > Notes: > Changes since v1: > - Drop minItems > - Add reg-names properties to example > > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Heiko, On Mon, May 16, 2022 at 10:12:26AM -0500, Rob Herring wrote: > On Wed, 11 May 2022 10:21:07 +0200, Sascha Hauer wrote: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and increase minItems to 2 as always both register spaces are needed. Could you drop the minItems part while applying? That is no longer correct. Sascha > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > > > Notes: > > Changes since v1: > > - Drop minItems > > - Add reg-names properties to example > > > > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> > >
On 14/05/2022 00:26, Heiko Stuebner wrote: > Hi Rob, Krzysztof, > > Am Mittwoch, 11. Mai 2022, 10:21:07 CEST schrieb Sascha Hauer: >> The VOP2 driver relies on reg-names properties, but these are not >> documented. Add the missing documentation, make reg-names mandatory >> and increase minItems to 2 as always both register spaces are needed. >> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > does this look ok now? Neither Rob nor me was Cced on original email, so I don't have it in my mailbox... I would expect that scripts/get_maintainers.pl is a known tool. Best regards, Krzysztof
Am Dienstag, 17. Mai 2022, 11:02:06 CEST schrieb Krzysztof Kozlowski: > On 14/05/2022 00:26, Heiko Stuebner wrote: > > Hi Rob, Krzysztof, > > > > Am Mittwoch, 11. Mai 2022, 10:21:07 CEST schrieb Sascha Hauer: > >> The VOP2 driver relies on reg-names properties, but these are not > >> documented. Add the missing documentation, make reg-names mandatory > >> and increase minItems to 2 as always both register spaces are needed. > >> > >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > does this look ok now? > > Neither Rob nor me was Cced on original email, so I don't have it in my > mailbox... I would expect that scripts/get_maintainers.pl is a known tool. Rob wrote in the past that he's working off of the devicetree-patchwork, and has reviewed the binding yesterday [0]. But you're right, including all the maintainers get_maintainers.pl suggests would be better in the future. [0] https://lore.kernel.org/r/20220516151226.GA2653888-robh@kernel.org
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 655d9b327f7d3..fba45091d9092 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml @@ -22,7 +22,6 @@ properties: - rockchip,rk3568-vop reg: - minItems: 1 items: - description: Must contain one entry corresponding to the base address and length @@ -31,6 +30,11 @@ properties: Can optionally contain a second entry corresponding to the CRTC gamma LUT address. + reg-names: + items: + - const: vop + - const: gamma-lut + interrupts: maxItems: 1 description: @@ -86,6 +90,7 @@ properties: required: - compatible - reg + - reg-names - interrupts - clocks - clock-names @@ -104,6 +109,7 @@ examples: vop: vop@fe040000 { compatible = "rockchip,rk3568-vop"; reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; + reg-names = "vop", "gamma-lut"; interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cru ACLK_VOP>, <&cru HCLK_VOP>,
The VOP2 driver relies on reg-names properties, but these are not documented. Add the missing documentation, make reg-names mandatory and increase minItems to 2 as always both register spaces are needed. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Notes: Changes since v1: - Drop minItems - Add reg-names properties to example .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)