| Message ID | 20220505115226.20130-1-rex-bc.chen@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | cpufreq: mediatek: Cleanup and support MT8183 and MT8186 | expand |
On 05-05-22, 19:52, Rex-BC Chen wrote: > Cpufreq is a DVFS driver used for power saving to scale the clock frequency > and supply the voltage for CPUs. This series do some cleanup for MediaTek > cpufreq drivers and add support for MediaTek SVS[2] and MediaTek CCI > devfreq[3] which are supported in MT8183 and MT8186. Applied 2-5, rest of them depend on the binding and dts patches to be Acked.
On Fri, 2022-05-06 at 09:50 +0530, Viresh Kumar wrote: > On 05-05-22, 19:52, Rex-BC Chen wrote: > > Cpufreq is a DVFS driver used for power saving to scale the clock > > frequency > > and supply the voltage for CPUs. This series do some cleanup for > > MediaTek > > cpufreq drivers and add support for MediaTek SVS[2] and MediaTek > > CCI > > devfreq[3] which are supported in MT8183 and MT8186. > > Applied 2-5, rest of them depend on the binding and dts patches to be > Acked. > Hello Viresh, Thanks for accepting our patches. As for rest patch: The cci series [1] is still under reviewing and it depends on chanwoo's series [2]. Therefore, I think it won't be so quick to be acked for these patches in my series. [1]: cci: https://lore.kernel.org/all/20220425125546.4129-1-johnson.wang@mediatek.com/ [2]: chanwoo's passive governor support for devfreq: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing BRs, Rex
On 06-05-22, 14:32, Rex-BC Chen wrote: > As for rest patch: > The cci series [1] is still under reviewing and it depends on chanwoo's > series [2]. > Therefore, I think it won't be so quick to be acked for these patches > in my series. I have applied 1, 6-7 now. I hope it is safe to apply them ? What about other three, can you get them acked now ?
On Thu, 2022-05-12 at 10:57 +0530, Viresh Kumar wrote: > On 06-05-22, 14:32, Rex-BC Chen wrote: > > As for rest patch: > > The cci series [1] is still under reviewing and it depends on > > chanwoo's > > series [2]. > > Therefore, I think it won't be so quick to be acked for these > > patches > > in my series. > > I have applied 1, 6-7 now. I hope it is safe to apply them ? What > about other > three, can you get them acked now ? > Hello Viresh, Thanks for your help! Matthias is not the member of mediatek, so I think we still need his feedback for these three patches. BRs, Rex
On 12-05-22, 13:33, Rex-BC Chen wrote: > Matthias is not the member of mediatek, so I think we still need his > feedback for these three patches. Please ping him and ask for his feedback then.
On Thu, 2022-05-12 at 11:18 +0530, Viresh Kumar wrote: > On 12-05-22, 13:33, Rex-BC Chen wrote: > > Matthias is not the member of mediatek, so I think we still need > > his > > feedback for these three patches. > > Please ping him and ask for his feedback then. > ok, I will do this. Thanks! BRs, Rex
On 12/05/2022 08:05, Rex-BC Chen wrote: > On Thu, 2022-05-12 at 11:18 +0530, Viresh Kumar wrote: >> On 12-05-22, 13:33, Rex-BC Chen wrote: >>> Matthias is not the member of mediatek, so I think we still need >>> his >>> feedback for these three patches. >> >> Please ping him and ask for his feedback then. >> > > ok, I will do this. > Thanks! > Sorry for the late reply. I'll take the DTS patches through my tree. As I'm late to the game this will be for v5.20. Regards, Matthias
On Tue, 2022-05-17 at 11:57 +0200, Matthias Brugger wrote: > > On 12/05/2022 08:05, Rex-BC Chen wrote: > > On Thu, 2022-05-12 at 11:18 +0530, Viresh Kumar wrote: > > > On 12-05-22, 13:33, Rex-BC Chen wrote: > > > > Matthias is not the member of mediatek, so I think we still > > > > need > > > > his > > > > feedback for these three patches. > > > > > > Please ping him and ask for his feedback then. > > > > > > > ok, I will do this. > > Thanks! > > > > Sorry for the late reply. I'll take the DTS patches through my tree. > As I'm late > to the game this will be for v5.20. > > Regards, > Matthias Hello Matthias, Thanks for you reply, I send another version for this series. Please refer to this: https://patchwork.kernel.org/project/linux-mediatek/list/?series=641933 BRs, Rex
Cpufreq is a DVFS driver used for power saving to scale the clock frequency and supply the voltage for CPUs. This series do some cleanup for MediaTek cpufreq drivers and add support for MediaTek SVS[2] and MediaTek CCI devfreq[3] which are supported in MT8183 and MT8186. Changes for v6: 1. Reorder patches in this series. 2. Add a new patch to do unregister platform device. 3. Modify drivers from maintainer's advice. Changes for v5: 1. Modify the description for the reason we need to use mediatek,cci. 2. Drop [07/14] cpufreq: mediatek: Add .get function. Changes for V4: 1. Revise drivers from reviewers' suggestion. 2. Fix name of opp table issue. Changes for V3: 1. Rebased to linux-next-20220414. 2. Drop accepted patches. 3. Drop "cpufreq: mediatek: Use maximum voltage in init stage" because we make sure the voltage we set is safe for both mediatek cci and cpufreq. 4. Rename cci property to mediatek,cci. 5. Adjust order of cleanup patches. 6. Add new patches for cleanup, handle infinite loop and MT8183 dts. 7. Revise drivers from reviewers' suggestion. 8. Revise commit message of some patches to avoid confusion and misunderstand. 9. Revise "cpufreq: mediatek: Link CCI device to CPU". We do not return successful to pretend we set the target frequency done when cci is not ready. Instead, we find and set a safe voltage so that we can set the target cpufrequency. Changes for V2: 1. Drop the modification of transforming cpufreq-mediatek into yaml and only add the MediaTek CCI property for MediaTek cpufreq. 2. Split the original patches into several patches. Reference series: [1]: V1 of this series is present by Jia-Wei Chang. https://lore.kernel.org/all/20220307122151.11666-1-jia-wei.chang@mediatek.com/ [2]: The MediaTek CCI devfreq driver is introduced in another series. https://lore.kernel.org/all/20220425125546.4129-1-johnson.wang@mediatek.com/ [3]: The MediaTek SVS driver is introduced in another series. https://lore.kernel.org/all/20220420102044.10832-1-roger.lu@mediatek.com/ Jia-Wei Chang (2): cpufreq: mediatek: Refine mtk_cpufreq_voltage_tracking() cpufreq: mediatek: Add support for MT8186 Rex-BC Chen (8): dt-bindings: cpufreq: mediatek: Add MediaTek CCI property cpufreq: mediatek: Add platform_device_unregister when driver exit cpufreq: mediatek: Move voltage limits to platform data cpufreq: mediatek: Add opp notification support cpufreq: mediatek: Link CCI device to CPU arm64: dts: mediatek: Add opp table and clock property for MT8183 cpufreq arm64: dts: mediatek: Add MediaTek CCI node for MT8183 arm64: dts: mediatek: Add mediatek,cci property for MT8183 cpufreq .../bindings/cpufreq/cpufreq-mediatek.txt | 7 + arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 36 ++ .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 + arch/arm64/boot/dts/mediatek/mt8183.dtsi | 285 +++++++++++++ drivers/cpufreq/mediatek-cpufreq.c | 400 ++++++++++++------ 5 files changed, 609 insertions(+), 123 deletions(-)