diff mbox

ethernet: add export.h in davinci_cpdma.c

Message ID A874F61F95741C4A9BA573A70FE3998FCAAB@DQHE02.ent.ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kim, Milo July 2, 2012, 1:17 a.m. UTC
To remove warning messages about 'EXPORT_SYMBOL_GPL', include export header.

drivers/net/ethernet/ti/davinci_cpdma.c:280: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:280: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:280: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:326: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:326: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:326: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:357: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:357: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:357: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:428: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:428: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:428: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:452: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:452: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:452: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:537: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:537: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:537: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:555: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:555: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:555: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:704: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:704: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:704: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:788: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:788: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:788: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:816: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:816: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:816: warning: parameter names (without types) in function declaration
drivers/net/ethernet/ti/davinci_cpdma.c:877: warning: data definition has no type or storage class
drivers/net/ethernet/ti/davinci_cpdma.c:877: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/net/ethernet/ti/davinci_cpdma.c:877: warning: parameter names (without types) in function declaration

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
 drivers/net/ethernet/ti/davinci_cpdma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

David Miller July 2, 2012, 1:33 a.m. UTC | #1
From: "Kim, Milo" <Milo.Kim@ti.com>
Date: Mon, 2 Jul 2012 01:17:03 +0000

> To remove warning messages about 'EXPORT_SYMBOL_GPL', include export header.
 ...
> @@ -19,6 +19,7 @@
>  #include <linux/err.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/io.h>
> +#include <linux/export.h>

You aren't generating this patch against current sources, otherwise
you'd see that linux/module.h is included in this driver and therefore
the problem you ran into is not possible.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller July 2, 2012, 1:34 a.m. UTC | #2
Also, networking patches should always be CC:'d to netdev@vger.kernel.org
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kim, Milo July 2, 2012, 2:07 a.m. UTC | #3
> > @@ -19,6 +19,7 @@
> >  #include <linux/err.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/io.h>
> > +#include <linux/export.h>
> 
> You aren't generating this patch against current sources, otherwise
> you'd see that linux/module.h is included in this driver and therefore
> the problem you ran into is not possible.

Oops ! This patch was generated based on the latest linux-omap tree, but similar code was already patched in linux-next tree.
Thanks for the notice.

Best Regards,
Milo -
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index d614c37..3c1e423 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -19,6 +19,7 @@ 
 #include <linux/err.h>
 #include <linux/dma-mapping.h>
 #include <linux/io.h>
+#include <linux/export.h>
 
 #include "davinci_cpdma.h"