diff mbox series

[v1,12/17] ARM: dts: imx6q-apalis: Add adv7280 video input

Message ID 20220516115846.58328-13-max.oss.09@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx6q-apalis: Misc improvements and newly added carrier | expand

Commit Message

Max Krummenacher May 16, 2022, 11:58 a.m. UTC 
From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

The Apalis iMX6 modules allow connecting a parallel video input.
Add support for our ADV7280 video input module but have it disabled.
This allows to enable it in an overlay per the current system
configuration.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---

 arch/arm/boot/dts/imx6qdl-apalis.dtsi | 30 +++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Fabio Estevam May 16, 2022, 12:10 p.m. UTC | #1 
Hi Max,

On Mon, May 16, 2022 at 8:59 AM Max Krummenacher <max.oss.09@gmail.com> wrote:

> +       adv_7280: adv7280@21 {
> +               compatible = "adi,adv7280";
> +               reg = <0x21>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_ipu1_csi0>;

I suggest passing "adv,force-bt656-4" property as this fixes sync problems.
Max Krummenacher May 18, 2022, 2:07 p.m. UTC | #2 
Hi Fabio

On Mon, May 16, 2022 at 2:10 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Max,
>
> On Mon, May 16, 2022 at 8:59 AM Max Krummenacher <max.oss.09@gmail.com> wrote:
>
> > +       adv_7280: adv7280@21 {
> > +               compatible = "adi,adv7280";
> > +               reg = <0x21>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_ipu1_csi0>;
>
> I suggest passing "adv,force-bt656-4" property as this fixes sync problems.

I will add the property in a V2 of the patchset. Thanks for the suggestion.
With my setup, i.e. PAL camera as the signal source I see no
noticeable change though.

Max
Fabio Estevam May 18, 2022, 2:10 p.m. UTC | #3 
Hi Max,

On Wed, May 18, 2022 at 11:07 AM Max Krummenacher <max.oss.09@gmail.com> wrote:

> I will add the property in a V2 of the patchset. Thanks for the suggestion.
> With my setup, i.e. PAL camera as the signal source I see no
> noticeable change though.

Correct. This property helps to fix the sync with NTSC video.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 0d1004eede62..f33dfaa907d7 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
@@ -418,6 +418,21 @@ 
 			  "MXM3_215";
 };
 
+&gpr {
+	ipu1_csi0_mux {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+
+		port@1 {
+			reg = <1>;
+			ipu1_csi0_mux_from_parallel_sensor: endpoint {
+				remote-endpoint = <&adv7280_to_ipu1_csi0_mux>;
+			};
+		};
+	};
+};
+
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
@@ -643,6 +658,21 @@ 
 	sda-gpios = <&gpio3 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 	status = "disabled";
 
+	adv_7280: adv7280@21 {
+		compatible = "adi,adv7280";
+		reg = <0x21>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_ipu1_csi0>;
+		status = "disabled";
+
+		port {
+			adv7280_to_ipu1_csi0_mux: endpoint {
+				bus-width = <8>;
+				remote-endpoint = <&ipu1_csi0_mux_from_parallel_sensor>;
+			};
+		};
+	};
+
 	ov5640_csi_cam: ov5640_mipi@3c {
 		compatible = "ovti,ov5640";
 		AVDD-supply = <&reg_ov5640_2v8_a_vdd>;