mbox series

[v4,0/3] block/dirty-bitmaps: fix and improve bitmap merge

Message ID 20220517111206.23585-1-v.sementsov-og@mail.ru (mailing list archive)
Headers show
Series block/dirty-bitmaps: fix and improve bitmap merge | expand

Message

Vladimir Sementsov-Ogievskiy May 17, 2022, 11:12 a.m. UTC
From: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>

v4:
01,03: add Kevin's r-b
02: add hbitmap_free() on success patch if local_backup is not needed

Vladimir Sementsov-Ogievskiy (3):
  block: block_dirty_bitmap_merge(): fix error path
  block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap
  block: simplify handling of try to merge different sized bitmaps

 include/block/block_int-io.h    |  2 +-
 include/qemu/hbitmap.h          | 15 ++-----------
 block/backup.c                  |  6 ++---
 block/dirty-bitmap.c            | 26 +++++++++------------
 block/monitor/bitmap-qmp-cmds.c | 40 ++++++++++++++++++---------------
 util/hbitmap.c                  | 25 ++++++---------------
 6 files changed, 45 insertions(+), 69 deletions(-)

Comments

Eric Blake May 18, 2022, 3:32 p.m. UTC | #1
On Tue, May 17, 2022 at 02:12:03PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> 
> v4:
> 01,03: add Kevin's r-b
> 02: add hbitmap_free() on success patch if local_backup is not needed
> 
> Vladimir Sementsov-Ogievskiy (3):
>   block: block_dirty_bitmap_merge(): fix error path
>   block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap
>   block: simplify handling of try to merge different sized bitmaps

I plan to queue this through my block bitmaps tree, if no other block
maintainer beats me to it (I may do a combined pull request for that
and NBD patches).
Kevin Wolf May 24, 2022, 12:47 p.m. UTC | #2
Am 17.05.2022 um 13:12 hat Vladimir Sementsov-Ogievskiy geschrieben:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> 
> v4:
> 01,03: add Kevin's r-b
> 02: add hbitmap_free() on success patch if local_backup is not needed
> 
> Vladimir Sementsov-Ogievskiy (3):
>   block: block_dirty_bitmap_merge(): fix error path
>   block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap
>   block: simplify handling of try to merge different sized bitmaps

Thanks, applied to the block branch.

Kevin