diff mbox series

thermal: intel: hfi: remove null check after call container_of()

Message ID 1652751061-23045-1-git-send-email-baihaowen@meizu.com (mailing list archive)
State Mainlined, archived
Headers show
Series thermal: intel: hfi: remove null check after call container_of() | expand

Commit Message

baihaowen May 17, 2022, 1:31 a.m. UTC
container_of() will never return NULL, so remove useless code.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/thermal/intel/intel_hfi.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Rafael J. Wysocki May 18, 2022, 6:54 p.m. UTC | #1
On Tue, May 17, 2022 at 3:31 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> container_of() will never return NULL, so remove useless code.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/thermal/intel/intel_hfi.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c
> index 730fd121df6e..a0640f762dc5 100644
> --- a/drivers/thermal/intel/intel_hfi.c
> +++ b/drivers/thermal/intel/intel_hfi.c
> @@ -243,8 +243,6 @@ static void hfi_update_work_fn(struct work_struct *work)
>
>         hfi_instance = container_of(to_delayed_work(work), struct hfi_instance,
>                                     update_work);
> -       if (!hfi_instance)
> -               return;
>
>         update_capabilities(hfi_instance);
>  }
> --

Applied with adjusted subject as 5.19 material, thanks!
diff mbox series

Patch

diff --git a/drivers/thermal/intel/intel_hfi.c b/drivers/thermal/intel/intel_hfi.c
index 730fd121df6e..a0640f762dc5 100644
--- a/drivers/thermal/intel/intel_hfi.c
+++ b/drivers/thermal/intel/intel_hfi.c
@@ -243,8 +243,6 @@  static void hfi_update_work_fn(struct work_struct *work)
 
 	hfi_instance = container_of(to_delayed_work(work), struct hfi_instance,
 				    update_work);
-	if (!hfi_instance)
-		return;
 
 	update_capabilities(hfi_instance);
 }