| Message ID | 20220518204901.93534-1-marex@denx.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e4920d42ce0e9c8aafb7f64b6d9d4ae02161e51e |
| Headers | show |
| Series | [v2] Input: ili210x - Fix reset timing | expand |
On Wed, May 18, 2022 at 10:49:01PM +0200, Marek Vasut wrote: > According to Ilitek "231x & ILI251x Programming Guide" Version: 2.30 > "2.1. Power Sequence", "T4 Chip Reset and discharge time" is minimum > 10ms and "T2 Chip initial time" is maximum 150ms. Adjust the reset > timings such that T4 is 12ms and T2 is 160ms to fit those figures. > > This prevents sporadic touch controller start up failures when some > systems with at least ILI251x controller boot, without this patch > the systems sometimes fail to communicate with the touch controller. > > Fixes: 201f3c803544c ("Input: ili210x - add reset GPIO support") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Applied, thank you.
diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c index 2bd407d86bae5..3a48262fb3d35 100644 --- a/drivers/input/touchscreen/ili210x.c +++ b/drivers/input/touchscreen/ili210x.c @@ -951,9 +951,9 @@ static int ili210x_i2c_probe(struct i2c_client *client, if (error) return error; - usleep_range(50, 100); + usleep_range(12000, 15000); gpiod_set_value_cansleep(reset_gpio, 0); - msleep(100); + msleep(160); } priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
According to Ilitek "231x & ILI251x Programming Guide" Version: 2.30 "2.1. Power Sequence", "T4 Chip Reset and discharge time" is minimum 10ms and "T2 Chip initial time" is maximum 150ms. Adjust the reset timings such that T4 is 12ms and T2 is 160ms to fit those figures. This prevents sporadic touch controller start up failures when some systems with at least ILI251x controller boot, without this patch the systems sometimes fail to communicate with the touch controller. Fixes: 201f3c803544c ("Input: ili210x - add reset GPIO support") Signed-off-by: Marek Vasut <marex@denx.de> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- V2: Use usleep_range() for shorter 12..15ms delay --- drivers/input/touchscreen/ili210x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)