| Message ID | 20220510031056.1657-3-ctcchien@nuvoton.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC: nuvoton: Add nuvoton NPCM memory controller driver | expand |
Dear Medad, Thank you for your patch. Am 10.05.22 um 05:10 schrieb Medad CChien: > Document devicetree bindings for the Nuvoton BMC NPCM memory controller. > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > > diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > new file mode 100644 > index 000000000000..6f37211796a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton NPCM Memory Controller > + > +maintainers: > + - Medad CChien <ctcchien@nuvoton.com> Just a side note, that in my experience functional like <linux-npcm-memory-controller@nuvoton.com> instead of personal addresses are useful, as you can configure on your side, who to deliver messages to. For example, if you are on sick leave or vacation, you just configure to deliver the message to a colleague of yours (or they get messages in the first place anyway). Maybe you can bring that up at Nuvoton. […] Kind regards, Paul
Dear Paul, thanks for your comment. Paul Menzel <pmenzel@molgen.mpg.de> 於 2022年5月10日 週二 下午2:14寫道： > > Dear Medad, > > > Thank you for your patch. > > Am 10.05.22 um 05:10 schrieb Medad CChien: > > Document devicetree bindings for the Nuvoton BMC NPCM memory controller. > > > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > > > > diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > > new file mode 100644 > > index 000000000000..6f37211796a3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Nuvoton NPCM Memory Controller > > + > > +maintainers: > > + - Medad CChien <ctcchien@nuvoton.com> > > Just a side note, that in my experience functional like > <linux-npcm-memory-controller@nuvoton.com> instead of personal addresses > are useful, as you can configure on your side, who to deliver messages > to. For example, if you are on sick leave or vacation, you just > configure to deliver the message to a colleague of yours (or they get > messages in the first place anyway). > > Maybe you can bring that up at Nuvoton. > I understand, but we do not have group email address. so maybe I should add more maintainers? > […] > > > Kind regards, > > Paul B.R. Medad
Dear Medad, Am 16.05.22 um 04:30 schrieb Medad Young: > Paul Menzel 於 2022年5月10日 週二 下午2:14寫道： >> Am 10.05.22 um 05:10 schrieb Medad CChien: >>> Document devicetree bindings for the Nuvoton BMC NPCM memory controller. >>> >>> Signed-off-by: Medad CChien <ctcchien@nuvoton.com> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >>> --- >>> .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++ >>> 1 file changed, 61 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml >>> new file mode 100644 >>> index 000000000000..6f37211796a3 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml >>> @@ -0,0 +1,61 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Nuvoton NPCM Memory Controller >>> + >>> +maintainers: >>> + - Medad CChien <ctcchien@nuvoton.com> >> >> Just a side note, that in my experience functional like >> <linux-npcm-memory-controller@nuvoton.com> instead of personal addresses >> are useful, as you can configure on your side, who to deliver messages >> to. For example, if you are on sick leave or vacation, you just >> configure to deliver the message to a colleague of yours (or they get >> messages in the first place anyway). >> >> Maybe you can bring that up at Nuvoton. > > I understand, but we do not have group email address. > so maybe I should add more maintainers? If there are actually more maintainers, responsible and knowledgeable for that driver, than yes, these should be added (until you get a function address set up). Kind regards, Paul
Dear Paul, Paul Menzel <pmenzel@molgen.mpg.de> 於 2022年5月18日 週三 下午12:33寫道： > > Dear Medad, > > > Am 16.05.22 um 04:30 schrieb Medad Young: > > > Paul Menzel 於 2022年5月10日 週二 下午2:14寫道： > > >> Am 10.05.22 um 05:10 schrieb Medad CChien: > >>> Document devicetree bindings for the Nuvoton BMC NPCM memory controller. > >>> > >>> Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >>> --- > >>> .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++ > >>> 1 file changed, 61 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > >>> new file mode 100644 > >>> index 000000000000..6f37211796a3 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml > >>> @@ -0,0 +1,61 @@ > >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Nuvoton NPCM Memory Controller > >>> + > >>> +maintainers: > >>> + - Medad CChien <ctcchien@nuvoton.com> > >> > >> Just a side note, that in my experience functional like > >> <linux-npcm-memory-controller@nuvoton.com> instead of personal addresses > >> are useful, as you can configure on your side, who to deliver messages > >> to. For example, if you are on sick leave or vacation, you just > >> configure to deliver the message to a colleague of yours (or they get > >> messages in the first place anyway). > >> > >> Maybe you can bring that up at Nuvoton. > > > > I understand, but we do not have group email address. > > so maybe I should add more maintainers? > > If there are actually more maintainers, responsible and knowledgeable > for that driver, than yes, these should be added (until you get a > function address set up). > OK, thanks > > Kind regards, > > Paul B.R. Medad
diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml new file mode 100644 index 000000000000..6f37211796a3 --- /dev/null +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton NPCM Memory Controller + +maintainers: + - Medad CChien <ctcchien@nuvoton.com> + +description: | + The Nuvoton BMC SoC supports DDR4 memory with and without ECC (error + correction check). + + The memory controller supports single bit error correction, double bit + error detection (in-line ECC in which a section (1/8th) of the memory + device used to store data is used for ECC storage). + + Note, the bootloader must configure ECC mode for the memory controller. + +properties: + compatible: + enum: + - nuvoton,npcm750-memory-controller + - nuvoton,npcm845-memory-controller + + reg: + maxItems: 1 + + interrupts: + minItems: 1 + items: + - description: uncorrectable error interrupt + - description: correctable error interrupt + + interrupt-names: + minItems: 1 + items: + - const: ue + - const: ce + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + ahb { + #address-cells = <2>; + #size-cells = <2>; + mc: memory-controller@f0824000 { + compatible = "nuvoton,npcm750-memory-controller"; + reg = <0x0 0xf0824000 0x0 0x1000>; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + }; + };