| Message ID | 20220514090522.1669270-7-yukuai3@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | multiple cleanup patches for bfq | expand |
On Sat 14-05-22 17:05:20, Yu Kuai wrote: > Such code are not even compiled since they are inside marco "#if 0". > > Signed-off-by: Yu Kuai <yukuai3@huawei.com> Sure. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > block/bfq-iosched.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 1d0141c450c0..e36a16684fb4 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -2322,22 +2322,6 @@ static sector_t get_sdist(sector_t last_pos, struct request *rq) > return 0; > } > > -#if 0 /* Still not clear if we can do without next two functions */ > -static void bfq_activate_request(struct request_queue *q, struct request *rq) > -{ > - struct bfq_data *bfqd = q->elevator->elevator_data; > - > - bfqd->rq_in_driver++; > -} > - > -static void bfq_deactivate_request(struct request_queue *q, struct request *rq) > -{ > - struct bfq_data *bfqd = q->elevator->elevator_data; > - > - bfqd->rq_in_driver--; > -} > -#endif > - > static void bfq_remove_request(struct request_queue *q, > struct request *rq) > { > -- > 2.31.1 >
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 1d0141c450c0..e36a16684fb4 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -2322,22 +2322,6 @@ static sector_t get_sdist(sector_t last_pos, struct request *rq) return 0; } -#if 0 /* Still not clear if we can do without next two functions */ -static void bfq_activate_request(struct request_queue *q, struct request *rq) -{ - struct bfq_data *bfqd = q->elevator->elevator_data; - - bfqd->rq_in_driver++; -} - -static void bfq_deactivate_request(struct request_queue *q, struct request *rq) -{ - struct bfq_data *bfqd = q->elevator->elevator_data; - - bfqd->rq_in_driver--; -} -#endif - static void bfq_remove_request(struct request_queue *q, struct request *rq) {
Such code are not even compiled since they are inside marco "#if 0". Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- block/bfq-iosched.c | 16 ---------------- 1 file changed, 16 deletions(-)