diff mbox series

RDMA/rxe: goto error handling when detecting invalid opcode

Message ID 20220519083049.2259564-1-cgxu519@mykernel.net (mailing list archive)
State Rejected
Headers show
Series RDMA/rxe: goto error handling when detecting invalid opcode | expand

Commit Message

Chengguang Xu May 19, 2022, 8:30 a.m. UTC 
Currently in rxe_requester() we just skip further operation
instead of going error handling when detecting invalid opcode.

IMO, it should goto error handling just like other errors.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Li Zhijian May 19, 2022, 9:20 a.m. UTC | #1 
looks it's duplicated with

https://patchwork.kernel.org/project/linux-rdma/patch/20220410113513.27537-1-yangx.jy@fujitsu.com/

and it was already applied.


On 19/05/2022 16:30, Chengguang Xu wrote:
> Currently in rxe_requester() we just skip further operation
> instead of going error handling when detecting invalid opcode.
>
> IMO, it should goto error handling just like other errors.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> ---
>   drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index ae5fbc79dd5c..8a1cff80a68e 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -661,7 +661,7 @@ int rxe_requester(void *arg)
>   	opcode = next_opcode(qp, wqe, wqe->wr.opcode);
>   	if (unlikely(opcode < 0)) {
>   		wqe->status = IB_WC_LOC_QP_OP_ERR;
> -		goto exit;
> +		goto err;
>   	}
>   
>   	mask = rxe_opcode[opcode].mask;
Chengguang Xu May 19, 2022, 2:42 p.m. UTC | #2 
在 2022/5/19 17:20, lizhijian@fujitsu.com 写道:
> looks it's duplicated with
>
> https://patchwork.kernel.org/project/linux-rdma/patch/20220410113513.27537-1-yangx.jy@fujitsu.com/
>
> and it was already applied.

Ah, it's my fault, please ignore this patch.


Thanks,
Chengguang
diff mbox series

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index ae5fbc79dd5c..8a1cff80a68e 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -661,7 +661,7 @@  int rxe_requester(void *arg)
 	opcode = next_opcode(qp, wqe, wqe->wr.opcode);
 	if (unlikely(opcode < 0)) {
 		wqe->status = IB_WC_LOC_QP_OP_ERR;
-		goto exit;
+		goto err;
 	}
 
 	mask = rxe_opcode[opcode].mask;