mbox series

[stable,4.19,0/3] MMC timeout back ports

Message ID 20220517182211.249775-1-f.fainelli@gmail.com (mailing list archive)
Headers show
Series MMC timeout back ports | expand

Message

Florian Fainelli May 17, 2022, 6:22 p.m. UTC
These 3 commits from upstream allow us to have more fine grained control
over the MMC command timeouts and this solves the following timeouts
that we have seen on our systems across suspend/resume cycles:

[   14.907496] usb usb2: root hub lost power or was reset
[   15.216232] usb 1-1: reset high-speed USB device number 2 using
xhci-hcd
[   15.485812] bcmgenet 8f00000.ethernet eth0: Link is Down
[   15.525328] mmc1: error -110 doing runtime resume
[   15.531864] OOM killer enabled.

Thanks!

Ulf Hansson (3):
  mmc: core: Specify timeouts for BKOPS and CACHE_FLUSH for eMMC
  mmc: block: Use generic_cmd6_time when modifying
    INAND_CMD38_ARG_EXT_CSD
  mmc: core: Default to generic_cmd6_time as timeout in __mmc_switch()

 drivers/mmc/core/block.c   |  6 +++---
 drivers/mmc/core/mmc_ops.c | 25 +++++++++++++------------
 2 files changed, 16 insertions(+), 15 deletions(-)

Comments

Florian Fainelli May 19, 2022, 5:38 p.m. UTC | #1
On 5/17/2022 11:22 AM, Florian Fainelli wrote:
> These 3 commits from upstream allow us to have more fine grained control
> over the MMC command timeouts and this solves the following timeouts
> that we have seen on our systems across suspend/resume cycles:
> 
> [   14.907496] usb usb2: root hub lost power or was reset
> [   15.216232] usb 1-1: reset high-speed USB device number 2 using
> xhci-hcd
> [   15.485812] bcmgenet 8f00000.ethernet eth0: Link is Down
> [   15.525328] mmc1: error -110 doing runtime resume
> [   15.531864] OOM killer enabled.
> 
> Thanks!

Looks like I managed to introduce a build warning due to the unused 
timeout variable, let me submit a fresher version for 4.19, 4.14 and 4.9.
Florian Fainelli May 19, 2022, 7:04 p.m. UTC | #2
On 5/19/2022 10:38 AM, Florian Fainelli wrote:
> 
> 
> On 5/17/2022 11:22 AM, Florian Fainelli wrote:
>> These 3 commits from upstream allow us to have more fine grained control
>> over the MMC command timeouts and this solves the following timeouts
>> that we have seen on our systems across suspend/resume cycles:
>>
>> [   14.907496] usb usb2: root hub lost power or was reset
>> [   15.216232] usb 1-1: reset high-speed USB device number 2 using
>> xhci-hcd
>> [   15.485812] bcmgenet 8f00000.ethernet eth0: Link is Down
>> [   15.525328] mmc1: error -110 doing runtime resume
>> [   15.531864] OOM killer enabled.
>>
>> Thanks!
> 
> Looks like I managed to introduce a build warning due to the unused 
> timeout variable, let me submit a fresher version for 4.19, 4.14 and 4.9.

Only v4.19 and v4.14 required a v2, you can find both here:

https://lore.kernel.org/lkml/20220519184536.370540-1-f.fainelli@gmail.com/T/#t

https://lore.kernel.org/lkml/20220519190030.377695-1-f.fainelli@gmail.com/T/#t

Sorry about that, I will build with W=1 in the future to notice those 
set but unused variable warnings.

Thanks!
Greg Kroah-Hartman May 21, 2022, 2:40 p.m. UTC | #3
On Thu, May 19, 2022 at 12:04:59PM -0700, Florian Fainelli wrote:
> 
> 
> On 5/19/2022 10:38 AM, Florian Fainelli wrote:
> > 
> > 
> > On 5/17/2022 11:22 AM, Florian Fainelli wrote:
> > > These 3 commits from upstream allow us to have more fine grained control
> > > over the MMC command timeouts and this solves the following timeouts
> > > that we have seen on our systems across suspend/resume cycles:
> > > 
> > > [   14.907496] usb usb2: root hub lost power or was reset
> > > [   15.216232] usb 1-1: reset high-speed USB device number 2 using
> > > xhci-hcd
> > > [   15.485812] bcmgenet 8f00000.ethernet eth0: Link is Down
> > > [   15.525328] mmc1: error -110 doing runtime resume
> > > [   15.531864] OOM killer enabled.
> > > 
> > > Thanks!
> > 
> > Looks like I managed to introduce a build warning due to the unused
> > timeout variable, let me submit a fresher version for 4.19, 4.14 and
> > 4.9.
> 
> Only v4.19 and v4.14 required a v2, you can find both here:
> 
> https://lore.kernel.org/lkml/20220519184536.370540-1-f.fainelli@gmail.com/T/#t
> 
> https://lore.kernel.org/lkml/20220519190030.377695-1-f.fainelli@gmail.com/T/#t
> 
> Sorry about that, I will build with W=1 in the future to notice those set
> but unused variable warnings.

I've queued up the updates now, thanks.

greg k-h